Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PtyMaster missing Into<OwnedFd> #2547

Closed
Darksonn opened this issue Nov 27, 2024 · 1 comment · Fixed by #2548
Closed

PtyMaster missing Into<OwnedFd> #2547

Darksonn opened this issue Nov 27, 2024 · 1 comment · Fixed by #2548

Comments

@Darksonn
Copy link
Contributor

An implementation of AsFd was added previously in #2354, but this is not enough to safely convert the PtyMaster into e.g. a File. There should be a conversion from PtyMaster to OwnedFd to allow this.
@SteveLauC
Copy link
Member

Yeah, we should add this, std implements this for all the owned fd types

@SteveLauC SteveLauC linked a pull request Nov 27, 2024 that will close this issue
feat: impl Into<OwnedFd> for owned fd types #2548
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: impl Into<OwnedFd> for owned fd types SteveLauC/nix
2 participants
@Darksonn @SteveLauC