[BUG] unnecessary rebuilds with mkPoetryApplication when any files in projectDir change #1731
Comments
aMOPel
changed the title
|
Do you know if the relatively new fileset lib could work? https://www.tweag.io/blog/2023-11-28-file-sets/ |
|
I fixed it now with {
# ...
src = pkgs.lib.fileset.toSource {
root = ./.;
fileset = pkgs.lib.fileset.unions [
(pkgs.lib.fileset.fromSource (gitignore.gitignoreSource ./src))
./poetry.lock
./pyproject.toml
./README.md
];
};
}with I think part of the problem for me was that this repo uses nixpkgs gitignore The other part was my ignorance to the fact that things have to be gitignored to not be part of the build. You have to make sure everything that is not supposed to be part of the build is gitignored by the local IMO this should be documented in the readme. |
|
Could you add a PR to add this info to https://github.com/nix-community/poetry2nix?tab=readme-ov-file#faq? |
minimal-setup.tar.gz
Describe the issue
When setting
projectDirinmkPoetryApplication, the derivation depends on every file inprojectDir.It would be better if it just depended on
I believe that would be the intended behavior but it seems the
cleanPythonSources { src = projectDir; }is not working correctly.
Why does it matter?
Because there can be untracked files in the projectDir, like editor files, cache files, etc that cause rebuilds.
minimal example
code mostly copied from the blog post https://www.tweag.io/blog/2020-08-12-poetry2nix/
see attachment or:
minimal setup
imgapp/__init__.pydefault.nix:pyproject.toml:poetry.lock:nix/sources.json{ "nixpkgs": { "branch": "nixos-unstable", "description": "Nix Packages collection", "homepage": null, "owner": "NixOS", "repo": "nixpkgs", "rev": "2893f56de08021cffd9b6b6dfc70fd9ccd51eb60", "sha256": "1anwxmjpm21msnnlrjdz19w31bxnbpn4kgf93sn3npihi7wf4a8h", "type": "tarball", "url": "https://github.com/NixOS/nixpkgs/archive/2893f56de08021cffd9b6b6dfc70fd9ccd51eb60.tar.gz", "url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz" }, "poetry2nix": { "branch": "master", "description": "Convert poetry projects to nix automagically [maintainer=@adisbladis] ", "homepage": "", "owner": "nix-community", "repo": "poetry2nix", "rev": "4fd045cdb85f2a0173021a4717dc01d92d7ab2b2", "sha256": "0fskks5zc8cqby48ql2hklm6zj780y7vza5nmwx01f9rxrbw3yvr", "type": "tarball", "url": "https://github.com/nix-community/poetry2nix/archive/4fd045cdb85f2a0173021a4717dc01d92d7ab2b2.tar.gz", "url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz" } }nix/sources.nixnix-buildtouch testnix-build-> builds again unnecessarilyThe text was updated successfully, but these errors were encountered: