Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wrapper-attrs available on build.package #2958

Open
MattSturgeon opened this issue Feb 2, 2025 · 0 comments
Open

Make wrapper-attrs available on build.package #2958

MattSturgeon opened this issue Feb 2, 2025 · 0 comments

Comments

@MattSturgeon
Copy link
Member

In #2874 we moved the wrapped nvim package from build.package to build.nvimPackage, so that build.package could be the symlinkJoin that includes the optional man-docs and nixvim-print-init.

This is a little clunky, in that package attrs previously available in build.package are no longer available here.

Two ways we could solve this include:

  • not using symlinkJoin

We could bundle the extra bits directly into the package. E.g. using a postInstall hook.

This would mean changing enableMan would cause a full rebuild, but that's probably not a big deal for the wrapper package.

  • Inherit important/useful attrs as passthru attrs on the symlinkJoin.

This may be simpler, but would of course only expose the attrs we explicitly inherit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant