Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add descriptions so nix flake check passes #312

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Add descriptions so nix flake check passes #312

merged 1 commit into from
Oct 18, 2023

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Oct 18, 2023

Otherwise, nix flake check fails:

grahamc@Grahams-Air naersk % nix flake show --no-write-lock-file
warning: not writing modified lock file of flake 'git+file:///Users/grahamc/projects/naersk':
• Added input 'nixpkgs':
    'github:NixOS/nixpkgs/12bdeb01ff9e2d3917e6a44037ed7df6e6c3df9d' (2023-10-15)
git+file:///Users/grahamc/projects/naersk?ref=refs/heads/master&rev=3f976d822b7b37fc6fb8e6f157c2dd05e7e94e89
error: attribute 'defaultTemplate.description' does not exist

Patryk27
Patryk27 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@Patryk27 Patryk27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I wouldn't have thought those are required - thanks 🙂

@Patryk27 Patryk27 merged commit 636a9b5 into nix-community:master Oct 18, 2023
5 checks passed
@grahamc grahamc deleted the nix-flake-check branch October 18, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patryk27 Patryk27 Patryk27 approved these changes

@nmattia nmattia Awaiting requested review from nmattia nmattia is a code owner

@Anderssorby Anderssorby Awaiting requested review from Anderssorby Anderssorby is a code owner

@blitz blitz Awaiting requested review from blitz blitz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamc @Patryk27