Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emacs-pgtk fails to build #455

Open
drishal opened this issue Dec 16, 2024 · 7 comments
Open

emacs-pgtk fails to build #455

drishal opened this issue Dec 16, 2024 · 7 comments

Comments

@drishal
Copy link

drishal commented Dec 16, 2024 •
edited
Loading

emacs-pgtk fails with the following

       last 25 log lines:
       >        one display, but if you use more than one and close one of them
       >        Emacs may crash.
       >        See https://gitlab.gnome.org/GNOME/gtk/issues/221
       > checking for malloc_trim... yes
       > checking for dbus-1 >= 1.0... yes
       > checking for dbus_watch_get_unix_fd... yes
       > checking for dbus_type_is_valid... yes
       > checking for dbus_validate_bus_name... yes
       > checking for dbus_validate_path... yes
       > checking for dbus_validate_interface... yes
       > checking for dbus_validate_member... yes
       > checking for dbus_message_set_allow_interactive_authorization... yes
       > checking for gio-2.0 >= 2.26... yes
       > checking whether GSettings is in gio... yes
       > checking for gobject-2.0 >= 2.0... yes
       > checking for lgetfilecon in -lselinux... yes
       > checking for gnutls >= 2.12.2... yes
       > checking for libsystemd >= 222... yes
       > checking for tree-sitter >= 0.20.2... yes
       > checking for sys/inotify.h... yes
       > checking for inotify_init... yes
       > checking for inotify_init1... yes
       > checking for webkit2gtk-4.1 >= 2.12 webkit2gtk-4.1 < 2.41.92... no
       > checking for webkit2gtk-4.0 >= 2.12 webkit2gtk-4.0 < 2.41.92... no
       > configure: error: xwidgets requested but WebKitGTK+ or WebKit framework not found.

the code which I use to build packages:

  environment.systemPackages = with pkgs; [
      ((emacsPackagesFor emacs-pgtk).emacsWithPackages (
     epkgs: with epkgs; [
       treesit-grammars.with-all-grammars
       vterm

     ]
   ))
  ]
@vikanezrimaya
Copy link

Temporary workaround: emacs-pgtk.override { withXwidgets = false; }.

@vikanezrimaya
Copy link

Possibly related to #454

@jian-lin
Copy link
Member

#456 works around this issue. Please update emacs-overlay and this issue should disappear.

jian-lin added a commit to linj-fork/nixpkgs that referenced this issue Dec 17, 2024
@jian-lin
emacs: fix default values of withFoo flags after overrideAttrs
19e5b17 
Previously, the normal way to override src and version led to wrong
default values of withFoo flags.

Here is an minimal reproducible example for withXwidgets which should
default to false when version >= 30.

```console
$ nix eval --include nixpkgs=$PWD --impure --expr '
let pkgs = import <nixpkgs> { config = { }; overlays = [ ]; };
in (pkgs.emacs29-pgtk.overrideAttrs { version = "30"; }).withXwidgets
'
true
```

This fix keeps backward compatibility for the .override interface.

Fixes: nix-community/emacs-overlay#455
@jian-lin jian-lin mentioned this issue Dec 17, 2024
Open
13 tasks
@lheckemann
Copy link
Contributor

Can confirm that updating emacs-overlay to integrate the merge of #456 fixed the build for me, so I'd suggest closing :)

@jian-lin
Copy link
Member

This issue may be (ab)used to track a proper fix (NixOS/nixpkgs#365784 may be one). However, I am also fine with closing it.

@drishal
Copy link
Author

drishal commented Dec 18, 2024 •
edited
Loading

I don't mind keeping this issue open as well if a proper fix has not yet been found

Edit: also as of now the current #456 works

@drishal
Copy link
Author

drishal commented Dec 18, 2024

However I have a small question, what's this WebKitGTK/framework even used for ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lheckemann @vikanezrimaya @drishal @jian-lin