Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding emacs-macport #214

Open
knl opened this issue Mar 16, 2022 · 7 comments
Open

Adding emacs-macport #214

knl opened this issue Mar 16, 2022 · 7 comments

Comments

@knl
Copy link

knl commented Mar 16, 2022

As this overlay tracks various emacs packages, I'm wondering would it make sense to add emacs-macport to it as well? If yes, I'm willing to add it.

@jhenahan
Copy link

I actually used the overlay with the Mac port for a while just by specifying it as the package as you would normally for one of the overlay versions (since it's tracked in nixpkgs). I expect the hard part will be getting CI working, but then again I certainly wouldn't hate having cached builds for more Darwin stuff.

@montchr
Copy link
Contributor

montchr commented Mar 28, 2022

I actually used the overlay with the Mac port for a while just by specifying it as the package as you would normally for one of the overlay versions (since it's tracked in nixpkgs).

@jhenahan I didn't realize this was a thing. But re: "for a while": I'm curious why you stopped using it? Considering that it looks like emacs-mac (the source repo name on Bitbucket) now has native-comp support and it comes with the no-titlebar patch enabled by default, this is an interesting option to me.

I certainly wouldn't hate having cached builds for more Darwin stuff.

I certainly wouldn't hate that either. I would actually appreciate that quite a bit 😄

All that said, the version of emacs-mac/emacsMacport in nixpkgs (even the master branch) has not been updated to include support for native-comp / 28.0.92, but the source repo appears to add support for that version. https://bitbucket.org/mituharu/emacs-mac/src/work/

Considering that mituharu/railwaycat's repo is looks to me like a "fork" of Emacs with macOS-oriented patches applied, and the nixpkgs version is months out of date, I can totally see how emacs-mac would fit within the scope of emacs-overlay. The project has been around for quite a while and has a good reputation – e.g. doom-emacs recommends it as the most preferable Emacs package for macOS https://github.com/hlissner/doom-emacs/blob/master/docs/getting_started.org#with-homebrew

As this overlay tracks various emacs packages, I'm wondering would it make sense to add emacs-macport to it as well? If yes, I'm willing to add it.

@knl FWIW you've got my vote. I'm by no means involved in this project but let me know if you need a volunteer to test.

@montchr
Copy link
Contributor

montchr commented Mar 28, 2022

@Atemu
Copy link

Atemu commented Nov 20, 2022

FYI, the emacsMacport integration PR linked above has been merged which means it does include native-comp now and can be used more easily for the purposes of the overlay.

You only need to pass a source and macportVersion.

@dhess
Copy link

dhess commented Nov 20, 2022

Has anyone been able to get the upstreamed support to work on aarch64-darwin with this overlay? Mine always dies trying to build something clang- or llvm-related.

@Atemu
Copy link

Atemu commented Nov 21, 2022

This seems to be an issue on the Nixpkgs side though as other ports of this package work just fine.

@dhess
Copy link

dhess commented Nov 21, 2022

Yes, it's a nixpkgs issue, I was just curious whether anyone else had seen the issue, since you mentioned emacsMacport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants