Skip to content

passing user defined objects as an input #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
djarecka opened this issue Feb 26, 2021 · 3 comments
Closed

passing user defined objects as an input #433

djarecka opened this issue Feb 26, 2021 · 3 comments
Labels
question Further information is requested to consider suggesting changes that require more discussion

Comments

@djarecka
Copy link
Collaborator

I've been debugging code created by @harveyaa, and there is an issue when FunctionalImage is passed as an input. Even if we make sure that the image doesn't change during the execution, there is still issue with hash value. The task run fine, but because hash value is changing the task can't find the results.

In #432 I've added modified code from @harveyaa. I've also added a part to pydra to use cp.dumps to calculate the hash value for non-basic python objects and print statements to show where the hash value of img changes. It looks to me that ConcurrentFutures is responsible for this. Any idea?

@djarecka djarecka added the question Further information is requested label Feb 26, 2021
@satra
Copy link
Contributor

satra commented Feb 26, 2021

concurrent futures should not change the object. is the object itself being changed by the function that's using it?

@djarecka
Copy link
Collaborator Author

in original code it was changed, but not in the versioned i posted in #432

@tclose tclose added the to consider suggesting changes that require more discussion label Apr 1, 2025
@tclose
Copy link
Contributor

tclose commented Apr 29, 2025

#625, #791 and #784 should cover this problem I believe

@tclose tclose closed this as completed Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested to consider suggesting changes that require more discussion
Projects
None yet
Development

No branches or pull requests

3 participants