Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T2w and acq-hippo_T2w mixed up in report #1303

Open
dkp opened this issue Jun 1, 2024 · 5 comments
Open

T2w and acq-hippo_T2w mixed up in report #1303

dkp opened this issue Jun 1, 2024 · 5 comments
Labels

Comments

@dkp
Copy link

dkp commented Jun 1, 2024

What happened?

I ran MRIQC on data that has two T2w images: one is a partial volume hippocampus image; the other is a full volume T2w image.

What command did you use?

apptainer run --cleanenv --bind ${DATA}:/data:ro --bind ${APP_DERIV_DIR}:/outputs ${APP} \
/data /outputs participant --participant_label ${Subject} -m T1w T2w bold dwi -w ${WORK_DIR} --verbose-reports

What version of the software are you running?

Running MRIQC version 24.1.0.dev0+g3fe90466.d20240417

How are you running this software?

Singularity

Is your data BIDS valid?

Yes

Are you reusing any previously computed results?

No

Please copy and paste any relevant log output.

NA

Additional information / screenshots

It seems that separate svgs are being generated in the figures directory BUT the actual report for both the T2w and the acq-hippo_T2w are including the acq-hippo_T2w images and ignoring the regular T2w images.

A suitable test BIDS dataset with both types of T2w image is available here.

@dkp dkp added the bug label Jun 1, 2024
@oesteban
Copy link
Member

I believe #1317 may have resolved this -- if not completely, it definitely has a better approach to identify BIDS entities in the input file so a solution to this problem could be easy.

Thanks for the test dataset -- will check ASAP.

@dkp
Copy link
Author

dkp commented Aug 20, 2024

I reran it with 24.0.1 on our HPC. It crashed. I'm attaching the slurm log and mriqc logs in case they are useful.
crash-20240820-132230-dkp-UploadMetrics.a0-57081b1e-f896-441c-b618-94674e31bb7d.txt
mriqc-20240820-131213_d4e4380b-e5ac-4a53-9439-969b85ac4609.log
slurm-2088514.txt

@dkp
Copy link
Author

dkp commented Aug 28, 2024

I reran with 24.0.2 and it is much better:
A separate and correct report is generated for the T2_hippo scan (partial coverage T2).
Oddly, the main T2w report includes data for both the whole head T2 and the T2 hippo scan: They are correctly separated within the report.
However, this means that the T2_hippo scan information is reproduced in two places, which is okay, but perhaps not hat you were aiming for?

@oesteban
Copy link
Member

I'm quite overloaded so I'm not sure I'll be able to replicate this myself. Could you post screen captures of what you see?

@dkp
Copy link
Author

dkp commented Aug 29, 2024

@oesteban Here's a tar file with the results in it: https://www.dropbox.com/scl/fi/xkkia8d9ad2rktpbx4qhb/mriqc_dev.tar?rlkey=t3vlxew717q8kexcucjzc6z7t&st=lr4dmpcs&dl=0

Two T2w reports were generated: sub-CAM003_ses-01brain_T2w.html and sub-CAM003_ses-01brain_acq-hippo_T2w.html. That seems perfect.

The sub-CAM003_ses-01brain_acq-hippo_T2w.html is exactly what one would hope (it contains only results and images for this partial-volume T2w image).

However, the sub-CAM003_ses-01brain_T2w.html report contains data for both the T2w image AND the T2w-hippo image (i.e., twice as much data as should have been produced). Obviously, this is not a devastating issue as it just means the T2w-hippo data is replicated in 2 places.

I've attached a screenshot from sub-CAM003_ses-01brain_T2w.html to illustrate.
T2w_report_screenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants