You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
This is a minor annoyance, but the data type for some of the columns in events_to_df (and possibly some of the other DFExtractors), such as pick_count, station_count, etc., should really be an int instead of a float.
Because this would potentially force re-indexing of everyone's event bank's, I recommend waiting to address this until we address #195 and/or other index issues.
Versions (please complete the following information):
ObsPlus Version '0.2.6.dev1+g17d7abd'
The text was updated successfully, but these errors were encountered:
Looking a little more at what would be required to actually change this, obsplus.utils.pd._int_to_time_columns makes this more complicated than simply changing the dtype definition.
I am trying to remember exactly why, but I seem to recall there was a good reason these couldn't be ints. Perhaps its because there isn't a good way to represent NaN with default numpy ints?
I am trying to remember exactly why, but I seem to recall there was a good reason these couldn't be ints. Perhaps its because there isn't a good way to represent NaN with default numpy ints?
Yeah, that could be why. I know pandas has a nullable int now, but I don't think it's doable with numpy itself.
Description
This is a minor annoyance, but the data type for some of the columns in
events_to_df
(and possibly some of the other DFExtractors), such as pick_count, station_count, etc., should really be an int instead of a float.To Reproduce
Expected behavior
Here's the output of the above where I've noted which columns should be changed
Because this would potentially force re-indexing of everyone's event bank's, I recommend waiting to address this until we address #195 and/or other index issues.
Versions (please complete the following information):
The text was updated successfully, but these errors were encountered: