Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error detection during synchronized acquisition #54

Open
cmeyer opened this issue Dec 2, 2020 · 2 comments
Open

Improve error detection during synchronized acquisition #54

cmeyer opened this issue Dec 2, 2020 · 2 comments

Comments

@cmeyer
Copy link
Collaborator

cmeyer commented Dec 2, 2020

If synchronized acquisition fails, the timeout is long and the user is not given much indication that it has failed other than a Cancel button.

Ideally, the scan should throw an exception if it fails to start scanning within a reasonable amount of time.

Additionally, the overall timeout should be estimated more accurately.

And finally, if these conditions occur, the user should be clearly notified of the issue.

@jamesrussell216
Copy link

@Ion-e has this ticket got everything needed in it from #204? If so can you close the other one please?

@Ion-e
Copy link

Ion-e commented Jan 6, 2025

If synchronized acquisition fails, the timeout is long and the user is not given much indication that it has failed other than a Cancel button.

The "Cancel" button is not necessarily a confirmation that it failed, but that it's attempting to run the acquisition.

And finally, if these conditions occur, the user should be clearly notified of the issue.

Just to clarify, I would expect an Acquisition to notify the user even if it doesn't fulfil all the aforementioned criteria (i.e: the error triggered is different)

Aditionally:
The Cancel button should be responsive and cancel an acquisition as soon as possible.

Also I would add that on testing this fix, it should be tested in different types of Acquisition, not only Scan Synchronised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants