Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd party dependencies issues #12

Open
peter-budo opened this issue Jul 9, 2017 · 4 comments
Open

3rd party dependencies issues #12

peter-budo opened this issue Jul 9, 2017 · 4 comments

Comments

@peter-budo
Copy link

I was trying to got tools up to date and got blocked by

All com.android.support libraries must use the exact same version specification (mixing versions can lead to runtime crashes). Found versions 25.4.0, 25.3.1. Examples include com.android.support:animated-vector-drawable:25.4.0 and com.android.support:mediarouter-v7:24.3.1

After examining dependencies gradle -q dependencies app:dependencies --configuration compile found that

+--- com.afollestad.material-dialogs:core:0.9.4.3
|    +--- com.android.support:support-v13:25.3.1
|    |    +--- com.android.support:support-annotations:25.3.1 -> 25.4.0
|    |    \--- com.android.support:support-v4:25.3.1 -> 25.4.0 (*)
|    +--- com.android.support:appcompat-v7:25.3.1 -> 25.4.0 (*)
|    +--- com.android.support:recyclerview-v7:25.3.1 -> 25.4.0 (*)
|    +--- com.android.support:support-annotations:25.3.1 -> 25.4.0
|    \--- me.zhanghai.android.materialprogressbar:library:1.4.0
|         +--- com.android.support:appcompat-v7:25.3.1 -> 25.4.0 (*)
|         \--- com.android.support:support-annotations:25.3.1 -> 25.4.0

and

+--- com.simplecityapps:recyclerview-fastscroll:1.0.16
|    \--- com.android.support:recyclerview-v7:25.3.1 -> 25.4.0 (*)

are depended on support library 25.3.1 therefore blocking update to higher version

@karllindmark
Copy link
Collaborator

@peter-budo: Does this mean that it's "OK" at the moment, just that one can't really update the dependencies if they happen to use !25.3.1? 🤔

@peter-budo
Copy link
Author

You have to ask yourself if these libraries are that useful as to stick with them or you can actually do that extra leg work and have it done in your code and be free of unnecessary dependencies.

@karllindmark
Copy link
Collaborator

karllindmark commented Jul 10, 2017 via email

@peter-budo
Copy link
Author

Not a solution if owner is not doing further development on it and it is only you pushing for change on depended libraries. I would prefer own code, this is not 2012 and need for ActionBarSherlock 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants