Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review compare battle scars - possible improvement for future #13

Open
peter-budo opened this issue Mar 11, 2012 · 1 comment
Open

Review compare battle scars - possible improvement for future #13

peter-budo opened this issue Mar 11, 2012 · 1 comment

Comments

@peter-budo
Copy link
Collaborator

At the moment when comparing battle scars you have to know exact name of player otherwise some random name (at least that what appears to me without close code investigation) with same set of starting characters is used.
Example: I wanted to look up KnoxBE and forgotten that "BE" is at the end, so I typed Knox, returned user was Knox101.

We should investigate if there is way pre-check for 100% match in name, or how to retrieve list of options.

Second: There should be check if player has more then one persona and offer option to select which should be used for comparison.

Thirdly: As from what I seen in application, first are loaded data for "my" profile, then "compare to character". I believe it should be easy to then run simple compare function that could put in bold formatting on better performance data. Example:

12.9%        Accuracy        13.8%
402.96 m Longest headshot 326.88 m
@karllindmark
Copy link

#3 has been addressed in the batch of code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants