Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make library null-safe #12

Open
bit-burger opened this issue Apr 7, 2021 · 3 comments
Open

Make library null-safe #12

bit-burger opened this issue Apr 7, 2021 · 3 comments

Comments

@bit-burger
Copy link

As this package is not null safe, I went ahead and made the PR #11 to make the library null-safe (and therefore compatible with older versions), but also modernise the package (e.g. replace @required with required and also use TextButton instead of the deprecated FlatButton)

@ninest
Copy link
Owner

ninest commented Apr 8, 2021

Thank you for taking the time and effort to make these changes. I am unfortunately quite busy and do not have time to work on Flutter or this project. For now, I'll suggest making the repository with your changes the source of the package. I'm sorry about this.

I'll leave this PR open for when I have more time in the future

@bit-burger
Copy link
Author

Did not take long, just wanted to help on this awesome library :) , take your time you've done enough, at the moment I can't even update to null-safety, as the other libraries im depending on, are also still in an old version, so it doesn't really matter.

@aidanshilling
Copy link

Hi is this pull request going to be merged soon? I would love to use this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants