You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found several issues with back navigations in the hub:
Navigating back to empty root page
Navigating back from the first request page brings the user back to the empty root page.
This page should be skipped on back navigation.
Could be implemented by detecting whether we're on the root route or a sub-route, or alternatively by marking the page via a history state.
Navigating back overwrites history state
The router afterEach navigation guard in RpcApi does not distinguish between forward and backward navigation and always writes the history state. This leads to overwriting a previous page's history state with the next page's history state. Instead, for back navigations existing history states should not be overwritten.
The current bug leads to originalRouteName and intermediary keyguardResult getting lost, which results in not being able to (re)process keyguard results or resolving on intermediary requests which should actually continue with the original request.
Import in Checkout looses information about selected currency
When selecting NIM as payment currency in the checkout carousel and then logging in to an account, the Checkout loses the information about the selected currency when back in the carousel and shows all cards again. This is because the selected currency is stored in the history state but the switch from the import flow back to the carousel is a forward navigation with no access to the previous history state.
The selected currency should be stored in ssessionStorage to fix this bug.
[Partially Fixed] Navigating back from Ledger request views should stop ledger requests
E.g. when navigating back from SignTransactionLedger, i.e. leaving the view, stop signing and do not react to cancelled requests anymore.
This was the first bug I encountered, which I fixed by a commit directly on master.
I'll need to investigate whether a similar fix is also required for other Ledger request views.
I will fix the other bugs in the next days.
The text was updated successfully, but these errors were encountered:
I found several issues with back navigations in the hub:
Navigating back to empty root page
Navigating back from the first request page brings the user back to the empty root page.
This page should be skipped on back navigation.
Could be implemented by detecting whether we're on the root route or a sub-route, or alternatively by marking the page via a history state.
Navigating back overwrites history state
The router
afterEach
navigation guard inRpcApi
does not distinguish between forward and backward navigation and always writes the history state. This leads to overwriting a previous page's history state with the next page's history state. Instead, for back navigations existing history states should not be overwritten.The current bug leads to
originalRouteName
and intermediarykeyguardResult
getting lost, which results in not being able to (re)process keyguard results or resolving on intermediary requests which should actually continue with the original request.Import in Checkout looses information about selected currency
When selecting NIM as payment currency in the checkout carousel and then logging in to an account, the Checkout loses the information about the selected currency when back in the carousel and shows all cards again. This is because the selected currency is stored in the history state but the switch from the import flow back to the carousel is a forward navigation with no access to the previous history state.
The selected currency should be stored in
ssessionStorage
to fix this bug.[Partially Fixed] Navigating back from Ledger request views should stop ledger requests
E.g. when navigating back from
SignTransactionLedger
, i.e. leaving the view, stop signing and do not react to cancelled requests anymore.This was the first bug I encountered, which I fixed by a commit directly on master.
I'll need to investigate whether a similar fix is also required for other Ledger request views.
I will fix the other bugs in the next days.
The text was updated successfully, but these errors were encountered: