Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Workflow by Adding Initial Danger Job #556

Open
nkhanh44 opened this issue Jul 1, 2024 · 0 comments
Open

Improve Workflow by Adding Initial Danger Job #556

nkhanh44 opened this issue Jul 1, 2024 · 0 comments

Comments

@nkhanh44
Copy link
Contributor

nkhanh44 commented Jul 1, 2024

Why

The current CI workflow runs Danger only after the build and test stages. By adding an initial Danger job before the build, we can catch code quality issues, style violations, and other immediate problems early in the process. This will provide faster feedback to developers and reduce the time spent on fixing issues that could have been detected earlier.

Workflows need this change:

  • .github/self_hosted_project_workflows/automatic_pull_request_review.yml
  • .github/project_workflows/automatic_pull_request_review.yml

Who Benefits?

  • iOS-chapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant