[#316] Use build number from CI/CD #451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarss
requested review from
suho,
blyscuit,
markgravity,
minhnimble,
nmint8m,
phongvhd93,
vnntsu,
ducbm051291,
Shayokh144,
Thieurom and
nkhanh44
as code owners
|
@edgarss FYI, you can create the PR as a draft during development, and you then can set it ready for review. So no need to mark [WIP] on the title. |
ducbm051291
force-pushed
the
feature/316-build-number-from-ci
branch
from
06af457
to
393c0da
Compare
ducbm051291
force-pushed
the
feature/316-build-number-from-ci
branch
from
06261d3
to
f3d5e0f
Compare
ducbm051291
changed the title
ducbm051291
force-pushed
the
feature/316-build-number-from-ci
branch
from
57598e6
to
d45f2a4
Compare
ducbm051291
changed the title
|
@ducbm051291 This pull request opened months ago, please continue the work |
Remove redundant code
ducbm051291
force-pushed
the
feature/316-build-number-from-ci
branch
from
2c00b54
to
d3c55a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened 👀
CI/CD tools like Bitrise, GitHubAction, and Codemagic provide the build number so we can use that for the build number of the application. We will update our templates for Bitrise and GitHubAction to get the following benefit:
It is easier to track the commit of a version.
Make the build number more predictable.
Avoid duplicate build numbers when rebuilding the same commit (after registering a new device, we must re-deploy the app).
CI machines don't have to clone the whole project history to get the correct number of commits, reducing the overall build time and the cost of running CI/CD.
Insight 📝
ios-bump-versionstep in github workflowset-xcode-build-numberstep in bitriseProof Of Work 📹
coming soon