Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supply **kwargs to all methods of all routers #42

Open
nilsnolde opened this issue Aug 20, 2021 · 2 comments
Open

supply **kwargs to all methods of all routers #42

nilsnolde opened this issue Aug 20, 2021 · 2 comments

Comments

@nilsnolde
Copy link
Owner

nilsnolde commented Aug 20, 2021

in #41 (comment) we realized that the **kwargs are not even used when they're passed to a method. instead of removing that parameter, we should make use of it and simply append the whole thing to the request parameters. reason is that we likely won't keep up here with all the changes of the individual router arguments to APIs which will be added in the future and this provides a means of passing those anyways, sort of a safety net for our (and the community's!!!) laziness;)

@nurikk
Copy link
Contributor

nurikk commented Dec 15, 2021

This is exactly what I need! I've created PR adding kwargs support for osrm #49

@nurikk
Copy link
Contributor

nurikk commented Mar 15, 2022

Please help to review
#59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants