Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation inconsistent in modeling multi-phase site meters #26

Open
davidwe opened this issue Jan 10, 2017 · 2 comments
Open

Documentation inconsistent in modeling multi-phase site meters #26

davidwe opened this issue Jan 10, 2017 · 2 comments

Comments

@davidwe
Copy link

davidwe commented Jan 10, 2017

What should be assigned to submeter_of if you have a 3-phase main meter and you know to which specific line the submeters are connected?

The 3-phase main meter is modeled as the first three entries in the dict elec_meters, which are all site_meters.

  • In the tutorial (Chapter 1.1.1 Simple example in nilm_metadata/docs/source/tutorial.rst) every submeter is submeter_of one of this main meters, so either 1 or 2.
  • But in the documentation of ElecMeter (Chapter 2.4 in nilm_metadata/docs/source/dataset_metadata.rst) it says (even twice in a paragraph) "All non-site-meters directly downstream of the site meters should set submeter_of=0. Optionally also use phase to describe which phase this meter measures." In the metadata for REDD it's done this way, too, but without specifying the phase field.

So which is the right way to do it?

@JackKelly
Copy link
Contributor

JackKelly commented Jan 10, 2017

If you know the specific phase each submeter is connected to then please specify the precise site meter. (i.e. option 1 in your list)

Please only use submeter_of=0 if you don't know which exact site meter is upstream. This is the case in REDD: we don't know which of the two site meters is upstream of each submeter.

@davidwe
Copy link
Author

davidwe commented Jan 11, 2017

Okay, that is also the way I have done it. Thanks for the quick response!

I was asking that because I get RuntimeError: Tree has more than one root! when calling for example elec.describe() from nilmtk on my dataset. Do I have to read that error as "not implemented yet" or "you modeled your electric installation wrong"? Do I maybe have to split the network into three subtrees manually?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants