Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip_source_filep_create fails on Windows with a large zip archive #451

Open
ktakahashimtb opened this issue Aug 22, 2024 · 0 comments
Open
Labels
bug libzip doesn't behave as expected.

Comments

@ktakahashimtb
Copy link
Contributor

Describe the Bug
zip_source_filep_create fails on Windows when the size of zip archive is greater than ~2.14GB (== INT_MAX).

Expected Behavior
zip_source_filep_create and subsequent zip_open_from_source should be able to handle 2.14GB+ size archive on Windows.
The same archive can be opened via zip_open on Windows.

Observed Behavior
zip_source_filep_create fails with ZIP_ER_READ.

To Reproduce
On Windows, execute zip_source_filep_create with the file descriptor obtained for the large file.

libzip Version
v1.10.1 and also the tip of main

Operating System
Windows

Test Files
Any archive with size > 2.14GB.

Additional context
I'll follow up with a PR with a suggestion on how to address this limitation.

@ktakahashimtb ktakahashimtb added the bug libzip doesn't behave as expected. label Aug 22, 2024
@ktakahashimtb ktakahashimtb changed the title zip_source_filep_create fails on Windows when the size of zip archive is greater than ~2.14GB zip_source_filep_create fails on Windows with a large zip archive Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug libzip doesn't behave as expected.
Projects
None yet
Development

No branches or pull requests

1 participant