Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings while installing Nightwatch #4306

Open
garg3133 opened this issue Nov 18, 2024 · 16 comments · May be fixed by #4311
Open

Fix deprecation warnings while installing Nightwatch #4306

garg3133 opened this issue Nov 18, 2024 · 16 comments · May be fixed by #4311
Assignees
@souravkv
Labels
good first issue

Comments

@garg3133
Copy link
Member

Description of the bug/issue

During the installation of Nightwatch using the npm i -D nightwatch command, the following deprecation warnings are encountered:

image

Steps to reproduce

Install Nightwatch in an existing Node project: npm i -D nightwatch.

To create a new Node project:

  • mkdir test-project
  • cd test-project
  • npm init

Sample test

No response

Command to run

No response

Verbose Output

No response

Nightwatch Configuration

No response

Nightwatch.js Version

3.9.0

Node Version

No response

Browser

No response

Operating System

No response

Additional Information

No response
@ansh7432
Copy link

Heyy can i work on this issue could you please assign this to me ?

@garg3133
Copy link
Member Author

@ansh7432 Sure, go ahead!

@ansh7432
Copy link

ansh7432 commented Nov 19, 2024 •
edited
Loading

Hey,
I recently updated the glob package to version 11.0.0 in project, and fixed this issue and updated the node version
image

@ansh7432
Copy link

I had raised the pr please check that

@souravkv
Copy link

souravkv commented Nov 22, 2024 •
edited
Loading

Hello @garg3133 , could you please guide me because seems like mocha and archiver-utils uses older versions of glob which is transitive causing the issue . I think overriding glob :^9.0.0 only works locally but it won't work while publishing to npm , so is it possible to force them to use glob 9.0.0 or above in npm package ?

@garg3133
Copy link
Member Author

@souravkv Older version of archiver-utils is coming from archiver and an older version of archiver is coming from @nightwatch/nightwatch-inspector.

So, we would need to update the nightwatch-inspector package to the issue coming from the archiver-utils package.

@souravkv
Copy link

souravkv commented Nov 23, 2024 •
edited
Loading

@garg3133 Ok , fixing nightwatch-inspector to use newer archiver would fix it , but what about mocha , latest mocha still uses glob 8.1.0
image

@souravkv
Copy link

@garg3133 should I open a issue in nightwatch-inspector repo asking to update to newer version of archiver to fix deprecated glob?

@Shyam-Raghuwanshi Shyam-Raghuwanshi linked a pull request Nov 24, 2024 that will close this issue
Open
9 tasks
@garg3133
Copy link
Member Author

@souravkv You can. Also, feel free to raise a PR to update the version of archiver in nightwatch-inspector repository.

@garg3133
Copy link
Member Author

A PR to bump the version of glob in mocha was just merged yesterday: mochajs/mocha#5250

@souravkv
Copy link

@garg3133 ok I just raised a PR in nightwatch-inspector repository . also could you please assign this issue to me.

Harshit-7373 added a commit to Harshit-7373/nightwatch that referenced this issue Nov 26, 2024
@Harshit-7373
# issue-4306
a19a90b 
Fix deprecation warnings while installing Nightwatch nightwatchjs#4306.

1. Update Node.js.

2.Update dependencies using --legacy-peer  to ignore peer dependency conflicts and proceed with the installation anyway.

3.Update nightwatch to latest version.
4.Check issues with the node modules and package-lock.json.

5.Then , download the dependencies.
@Harshit-7373 Harshit-7373 mentioned this issue Nov 27, 2024
Closed
9 tasks
@garg3133
Copy link
Member Author

garg3133 commented Dec 4, 2024

@souravkv A new version of nightwatch-inspector has been released.

@souravkv souravkv mentioned this issue Dec 4, 2024
Open
@souravkv
Copy link

souravkv commented Dec 4, 2024

@garg3133 Ok , I have just raised a PR.

This was referenced Dec 4, 2024
Open
Open
Open
@souravkv
Copy link

souravkv commented Dec 4, 2024

@garg3133 I have opened three separate PR to address breaking changes.

@Anshuman-Jha-01
Copy link

/attempt #4306

@Anshuman-Jha-01 Anshuman-Jha-01 mentioned this issue Dec 19, 2024
Open
@Anshuman-Jha-01
Copy link

Fixed in PR #4338. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@souravkv souravkv

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix:fixing-warnings Shyam-Raghuwanshi/nightwatch
4 participants
@garg3133 @souravkv @ansh7432 @Anshuman-Jha-01