Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to redbug 2.x #52

Open
nietaki opened this issue Apr 12, 2021 · 4 comments · May be fixed by #55
Open

Migrate to redbug 2.x #52

nietaki opened this issue Apr 12, 2021 · 4 comments · May be fixed by #55

Comments

@nietaki
Copy link
Owner

nietaki commented Apr 12, 2021

redbug has been at 2.x for more than a year now, it's probably worth it to see how much work is required to support it.

I'm not actively working on any Elixir projects at the moment, so if anyone wants to give it a shot I'd be happy to help - I myself don't even have any projects where I could beta-test the new version while we work on it...

@nietaki
Copy link
Owner Author

nietaki commented Sep 23, 2022

It might be a good time to start working towards a 2.0 release, with redbug updated to 2.X, all dependencies updated and deprecation warnings fixed.

Rexbug 1.x supports Elixir starting from v 1.3 onwards (1.3 was released 6 years ago!) which makes it use some deprecated packages and approaches. I think this issue is a good moment to update everything to reflect the state of the ecosystem in 2022, even if it means dropping support for some older Elixir versions - those can still use rexbug 1.x, which was just updated with a bugfix today.

I personally haven't worked with Elixir for about 2 years now, so I'm a little rusty with it and don't have a hands on experience with the latest best practices. This is why it would really be helpful if some other people from the community could take a lead on that. I can offer a couple of hours a week of support if it's helpful :)

@bhuntpenn
Copy link

I can help out at weekends if you guide me a bit on how it fits together. DM @binarytemple on Twitter.

Just verified that redbug is supporting maps now, but it's hella ugly to express...

iex(200)> :redbug.start( ~C('Elixir.App.Marketplace.Projections.Selection':probability(#{'__struct__' => 'Elixir.Ratio' ,numerator => 0}\) -> stack;return ), max_msg_size: 500000, time: 45000, msgs: 1  )

Also, I checked out Rexbug and had a go at updating to redbug 2.0.5 but generated some errors that convinced me it would be worth chatting/pairing before embarking down the path of random hacking.

@velimir
Copy link

velimir commented Oct 12, 2022

Unless I'm missing something, the change that is relevant for the Rexbug should be around new type of meta calls:

massemanet/redbug@1.2.2...v2.0.0#diff-76dc3ee4e270fd76ca18de457773b47f4dd67a13ba00c78ff6d7cab2e24e14fbR367-R368

Taking dtop out of the cope.

@velimir velimir linked a pull request Oct 15, 2022 that will close this issue
@velimir
Copy link

velimir commented Oct 15, 2022

First attempt: #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants