Skip to content

Commit 2b30f18

Browse files
authored
Remove unused includes of php_random.h (php#13131)
Before this change php_random.h was listed in 146 different *.dep files for a env CC=clang ./configure --without-sqlite3 --without-pdo-sqlite build, after this change it's only listed in 110 of them, preventing uselessly recompiling those files when working on ext/random, mostly caused by the include in ext/standard/basic_functions.h.
1 parent e31bf3a commit 2b30f18

File tree

5 files changed

+0
-7
lines changed

5 files changed

+0
-7
lines changed

ext/dom/php_dom.c

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
#include "php.h"
2424
#if defined(HAVE_LIBXML) && defined(HAVE_DOM)
25-
#include "ext/random/php_random.h"
2625
#include "php_dom.h"
2726
#include "php_dom_arginfo.h"
2827
#include "dom_properties.h"

ext/standard/basic_functions.h

-3
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,6 @@
2727

2828
#include "url_scanner_ex.h"
2929

30-
/* for MT_N */
31-
#include "ext/random/php_random.h"
32-
3330
#if defined(_WIN32) && !defined(__clang__)
3431
#include <intrin.h>
3532
#endif

ext/standard/crypt.c

-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@
4343
#endif
4444

4545
#include "php_crypt.h"
46-
#include "ext/random/php_random.h"
4746

4847
/* Used to check DES salts to ensure that they contain only valid characters */
4948
#define IS_VALID_SALT_CHARACTER(c) (((c) >= '.' && (c) <= '9') || ((c) >= 'A' && (c) <= 'Z') || ((c) >= 'a' && (c) <= 'z'))

main/internal_functions_win32.c

-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
#include "ext/standard/php_array.h"
4040
#include "ext/standard/php_assert.h"
4141
#include "ext/reflection/php_reflection.h"
42-
#include "ext/random/php_random.h"
4342
#if HAVE_BCMATH
4443
#include "ext/bcmath/php_bcmath.h"
4544
#endif

main/reentrancy.c

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#endif
2323

2424
#include "php_reentrancy.h"
25-
#include "ext/random/php_random.h" /* for PHP_RAND_MAX */
2625

2726
enum {
2827
LOCALTIME_R,

0 commit comments

Comments
 (0)