Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Python script should be written for setup #34

Open
nicole-mcg opened this issue Apr 9, 2018 · 3 comments
Open

A Python script should be written for setup #34

nicole-mcg opened this issue Apr 9, 2018 · 3 comments
Labels
back end Python good first issue Good for newcomers structure This will make something more clear and less prone to programming errors

Comments

@nicole-mcg
Copy link
Owner

nicole-mcg commented Apr 9, 2018

It should move the existing setup.bat and setup.sh functionality to a python script and should also add new functionality:

  • Opening a browser page to the Python install link in the README (hard-coded) Clearly I didn't think this through
    • If the user isn't using windows, it should bring them to the proper OS install page for the version in the README
  • Opening a browser page to the Node.js install link in the README
    • Again, if the user isn't using windows, it should open the currect OS install page

A browser can be opened in Python using

import webbrowser
webbrowser.open('http://127.0.0.1:8080', new=2) #new=2 indicates it should open in a new tab if possible
@nicole-mcg nicole-mcg added back end Python good first issue Good for newcomers structure This will make something more clear and less prone to programming errors labels Apr 9, 2018
@parth-verma
Copy link

Hey, i'd like to take this up.

@parth-verma
Copy link

parth-verma commented Apr 21, 2018

According to me, it would be a better option to create this as a package downloadable via pip itself.

What do you think?

@nicole-mcg
Copy link
Owner Author

nicole-mcg commented Apr 21, 2018

@Party98 Hey, I actually created a script that fulfills my requirement. It doesn't work for Linux ATM. If this was replaced by downloading via pip, would it be able to download and install Java, and Node.js silently still?

Check run.bat which runs scripts/src/setup.ps1 which installs Python if it isn't currently installed. This then runs scripts/src/setup.py which installs Java and node if not installed and finally installs pip requirements and node modules

Repository owner deleted a comment from parth-verma Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back end Python good first issue Good for newcomers structure This will make something more clear and less prone to programming errors
Projects
None yet
Development

No branches or pull requests

2 participants