From 48de9c8e754da7c9cecf74ddacccdc9d0cf05a90 Mon Sep 17 00:00:00 2001 From: Nick Snyder Date: Sat, 14 Apr 2018 22:13:54 -0700 Subject: [PATCH] pr template --- .github/PULL_REQUEST_TEMPLATE.md | 15 +++++++++++++++ README.md | 8 -------- 2 files changed, 15 insertions(+), 8 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..c0149f6e --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,15 @@ +## What is the goal of this PR? + + + +## How does this PR accomplish the goal? + + + +## Checklist: + +* [ ] I have not made any changes that are backwards incompatible. +* [ ] I have read the [common code review comments](https://github.com/golang/go/wiki/CodeReviewComments). +* [ ] My code is formatted. +* [ ] My change is covered by unit tests. +* [ ] The build is passing. diff --git a/README.md b/README.md index 595e95f9..2f8ce67c 100644 --- a/README.md +++ b/README.md @@ -112,14 +112,6 @@ bundle.MustLoadMessageFile("active.es.toml") * Look at the [code examples](https://github.com/nicksnyder/go-i18n/blob/master/i18n/example_test.go) and [tests](https://github.com/nicksnyder/go-i18n/blob/master/i18n/localizer_test.go). * Look at an example [application](https://github.com/nicksnyder/go-i18n/tree/master/example). -## Contributions - -If you would like to submit a pull request, please - -1. Write tests. -2. Format code with [goimports](https://github.com/bradfitz/goimports). -3. Read the [common code review comments](https://github.com/golang/go/wiki/CodeReviewComments). - ## License go-i18n is available under the MIT license. See the [LICENSE](LICENSE) file for more info.