Begun adding configurable options and further scaffolding for strategies

Author: nickpellant

lib/faces.rb

@@ -1,4 +1,5 @@
 require 'rack'
+require 'hashie/mash'
 
 module Faces
   module Strategies

lib/faces/strategies/default.rb

@@ -2,6 +2,12 @@ module Faces
   module Strategies
     class Default
       include Faces::Strategy
+
+      option :default_src
+
+      def src
+        options.default_src
+      end
     end
   end
 end

lib/faces/strategy.rb

@@ -1,4 +1,46 @@
 module Faces
   module Strategy
+    def self.included(base)
+      base.extend ClassMethods
+    end
+
+    module ClassMethods
+      def default_options
+        return @default_options if instance_variable_defined?(:@default_options) && @default_options
+        existing = superclass.respond_to?(:default_options) ? superclass.default_options : {}
+        @default_options = Faces::Strategies::Options.new(existing)
+      end
+
+      def option(name, value = nil)
+        default_options[name] = value
+      end
+
+      def args(args = nil)
+        if args
+          @args = Array(args)
+          return
+        end
+        existing = superclass.respond_to?(:args) ? superclass.args : []
+        return (instance_variable_defined?(:@args) && @args) || existing
+      end
+    end
+  
+    attr_reader :app, :options
+
+    def initialize(app, *args, &block)
+      @app = app
+      @options = self.class.default_options.dup
+
+      options.deep_merge!(args.pop) if args.last.is_a?(Hash)
+
+      self.class.args.each do |arg|
+        options[arg] = args.shift
+      end
+    end
+  end
+
+
+  module Strategies
+    class Options < Hashie::Mash; end
   end
 end

spec/faces/strategies/default_spec.rb

@@ -1,7 +1,18 @@
 require 'spec_helper'
 
 describe Faces::Strategies::Default do
+  let(:app){ Rack::Builder.new do |b|
+    b.use Faces::Strategies::Default
+    b.run lambda{|env| [200, {}, ['Not Found']]}
+  end.to_app }
+
   subject do
-    Faces::Strategies::Default.new({})
+    Faces::Strategies::Default.new(app, {default_src: 'http://example.com'})
+  end
+
+  describe '#src' do
+    it 'returns the default image source' do
+      expect(subject.src).to eq('http://example.com')
+    end
   end
 end

spec/faces/strategy_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Faces::Strategy do
+  let(:fresh_strategy){ c = Class.new; c.send :include, Faces::Strategy; c}
+
+  describe '.default_options' do
+    it 'returns the default options' do
+      fresh_strategy.option 'test', 'correct'
+      expect(fresh_strategy.default_options).to eq(Faces::Strategies::Options.new({test: 'correct'}))
+    end
+  end
+
+  describe '.option' do
+    it 'sets an option for the strategy' do
+      expect(fresh_strategy.default_options).to eq(Faces::Strategies::Options.new())      
+      fresh_strategy.option 'test', 'correct'      
+      expect(fresh_strategy.default_options).to eq(Faces::Strategies::Options.new({test: 'correct'}))
+    end
+  end
+
+end