Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flattened format #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add flattened format #24

wants to merge 1 commit into from

Conversation

avilaton
Copy link

Hi @nickjj ,
we are using flask-webpack, thanks for creating it!.
We have an entry in our webpack.config.js that points to a js file, i.e.:

        customers: [
            rootAssetPath + '/src/client/apps/customers.js'
        ],

which, at some point, requires some stylesheets, i.e.

require('../styles/customer/main.scss');

var app = angular.module('app', [
    'ngRoute',
    'ngResource',
    'ui.bootstrap',
    'ui.mask'
]);

The resulting build contains a js file which we include in one of our pages using javascript_tag and a css file which we also want to include in that page. The css file is built correctly but it does not show in the resulting manifest.json file, so we made this format. I'm pretty sure this does not need to be included in your package but I thought I would submit the PR just in case. Maybe you have a suggestion of how we could do this without the custom format.

Again, thanks for this and for the awesome video you made explaining how it all fits together.

@nickjj
Copy link
Owner

nickjj commented Aug 26, 2016

Hi, thanks for the PR. Just wanted to say I glanced over things and will get back to you in a day or 2.

@avilaton
Copy link
Author

That's cool, not blocking us.
Thanks Nick.

El jue., 25 ago. 2016 9:09 p. m., Nick Janetakis [email protected]
escribió:

Hi, thanks for the PR. Just wanted to say I glanced over things and will
get back to you soon.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#24 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACG0_uhte0jGcNH0QSOnU4eSvczJFz2tks5qji6igaJpZM4Jr-tK
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants