Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

construct_label() should be able to take p-values. #503

Open
nickhaf opened this issue Feb 8, 2024 · 0 comments
Open

construct_label() should be able to take p-values. #503

nickhaf opened this issue Feb 8, 2024 · 0 comments
Labels
low priority No priority, take your time!

Comments

@nickhaf
Copy link
Owner

nickhaf commented Feb 8, 2024

          So, I've looked into it and the problem seems to be, that the p-column needs to contain TRUE and FALSE values instead of numeric values. That's because this function was used within another function, which converted the p-values into TRUE and FALSE values before using `construct_label()`. 

So for now you can just use TRUE/FALSE values in your example instead of p-values.
I will have to update the funciton a bit, so it can also take p-values, but I will open an Issue for that.

Originally posted by @nickhaf in #502 (comment)

@nickhaf nickhaf added the low priority No priority, take your time! label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority No priority, take your time!
Projects
None yet
Development

No branches or pull requests

1 participant