Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use real streams #4

Open
zeke opened this issue Mar 10, 2017 · 1 comment
Open

Use real streams #4

zeke opened this issue Mar 10, 2017 · 1 comment

Comments

@zeke
Copy link
Member

zeke commented Mar 10, 2017

As @wmhilton noted:

Your module exports an EventEmitter, not a stream.... I'm really into using stream facilities at the moment, like mississippi, and since level-graph has a db.putStream() function, I am taking the changes-stream stream, piping it through a map function, piping that into the database.

I've had a hard time making sense of how to use streams. They are conceptually simple, but implementation is another story. The stream implementation/interface has changed three times in node. To make matters worse, node hipsters eschew the built-in node streams in favor of userland modules for reasons that I don't fully understand.

So.. if anyone wants to work on making this package expose the same (or similar) interface while using real streams under the hood, I would be delighted.

@billiegoose
Copy link
Contributor

To make matters worse, node hipsters eschew the built-in node streams in favor of userland modules for reasons that I don't fully understand.

You're talking about pull-streams aren't you? (Because I don't think Tim-not-invented-here-Caswell's culvert has ever been used outside of js-git.)

Yeah... to make things worse I just learned that the Browser has its own (completely different) API for native streams, as far as I know only used in window.fetch. source: https://jakearchibald.com/2016/streams-ftw/

I get a strong sense that it's going to get worse before it gets better. 🤕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants