Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent results from codecov #1275

Open
texasaggie97-zz opened this issue Feb 14, 2020 · 2 comments
Open

Inconsistent results from codecov #1275

texasaggie97-zz opened this issue Feb 14, 2020 · 2 comments

Comments

@texasaggie97-zz
Copy link
Contributor

Description of issue

We are getting inconsistent result reported by codecov into the PRs. For example, #1251 shows a coverage decrease of 1.44% even though the only thing this PR does is add and remove blank lines in the .coverage.yml file.

I have started a discussion in the codecov support forums, but there has been no response.

@thomasrockhu
Copy link

Hi @texasaggie97, Tom from Codecov here. I responded to you in the community thread, but would you be able to push a new commit on top of #1251. Our systems have been upgraded in how we pick base and parent commits to compare against, and that might fix the issue. If not, I can go in manually and compare to see why this is happening for you.

@sbethur
Copy link
Contributor

sbethur commented May 19, 2020

Hi @thomasrockhu, master has drifted a lot compared to the state in #1251. I created another PR similar to that one - #1458 (comment). Looks like the changes on your end has fixed the inconsistency problem.

Coverage report from some other recent PRs also look good - #1451, #1452, #1457 - no unexpected changes in coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants