Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blazor .NET 8 support #1667

Open
1 of 11 tasks
rajsite opened this issue Nov 15, 2023 · 0 comments
Open
1 of 11 tasks

Blazor .NET 8 support #1667

rajsite opened this issue Nov 15, 2023 · 0 comments
Assignees
@msmithNI
Labels
enhancement New feature or request

Comments

@rajsite
Copy link
Member

rajsite commented Nov 15, 2023 •
edited by msmithNI
Loading

😯 Problem to Solve

We should come up with a plan for .NET 8 support. The Fluent folks made it a breaking change (might mostly be due to a namespace change) and added support for some. NET 8 specific features detailed in a blog

.NET 6 (our current version) goes out of active support in November 2024.

Here is a Teams thread discussing versions that existing clients use.

📋 Tasks

  • Create HLD - HLD: Blazor .NET 8 support #2411
  • Update TargetFramework from net6.0 to net8.0 for all BlazorWorkspace.sln projects
  • Update Microsoft.AspNetCore.Components.Web reference from 6.x to 8.x for all BlazorWorkspace.sln projects
  • Unpin analyzer versions (NI.CSharp.Analyzers, from [2.0.21]), update to latest - see Newer NI.CSharp.Analyzers 2.0.25 causes Nimble Blazor build issue #2014
  • Fix all errors/warnings: ~72 to resolve. Most common 3 are IDE0290 (Use primary constructor), IDE0028 (Collection initialization can be simplified), IDE0090 (new expression can be simplified). Alternatively suppress to start with, and create separate tech debt / PR to address fully.
  • Update examples: Re-build Demo.Server example app off of new "Blazor Web App" template ("Blazor Server App" template is now deprecated / cannot be targeted to .NET 8). Evaluate if Demo.Client/Demo.Server should be merged. Ensure Demo.Hybrid still works as expected.
  • Update NimbleBlazor and SprightBlazor README.md - location to add Nimble/Spright imports changed (no longer _Layout.cshtml for Blazor Server/ Web App variant, now App.razor)
  • Other doc updates (including CONTRIBUTING, updating SDK version references). Document supported Blazor render modes.
  • Further investigations on Possible race condition showing Blazor NimbleDialog during OnAfterRenderAsync #2188 (which may be specific to .NET 8)
  • Blazor EventCallbacks are not invoked with apps using .NET 8 template #2355
  • Evaluate that Playwright tests are written to sufficiently test .NET 8 apps. For example our existing tests didn't catch the issue above.

Before completing this work, we also want to check the upgrade status of our Blazor clients to see if they're ready to uptake a .NET 8 NimbleBlazor.
@rajsite rajsite added enhancement New feature or request triage New issue that needs to be reviewed labels Nov 15, 2023
@m-akinc m-akinc removed the triage New issue that needs to be reviewed label Nov 28, 2023
@jattasNI jattasNI mentioned this issue Jul 1, 2024
Open
@jattasNI jattasNI mentioned this issue Aug 26, 2024
Open
@msmithNI msmithNI self-assigned this Sep 11, 2024
@msmithNI msmithNI mentioned this issue Sep 25, 2024
Merged
msmithNI added a commit that referenced this issue Sep 25, 2024
@msmithNI
HLD: Blazor .NET 8 support (#2411)
691c1f3 
# Pull Request

## 🤨 Rationale

HLD for #1667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msmithNI msmithNI

Labels
enhancement New feature or request
Projects
Nimble Design System Priorities
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rajsite @m-akinc @msmithNI