New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR build should run ni-python-styleguide on all handwritten code #556

Open

bkeryan opened this issue Apr 2, 2024 · 0 comments

Labels

Collaborator

bkeryan commented Apr 2, 2024

src/handwritten is currently excluded from both [tool.black] and [tool.ni-python-styleguide]: https://github.com/ni/nidaqmx-python/blob/master/pyproject.toml#L77

[tool.black]
line-length = 100
extend_exclude = ".tox/|docs/|generated/|src/codegen/metadata/|src/codegen/templates/|src/handwritten/"

[tool.ni-python-styleguide]
extend_exclude = ".tox,docs,generated,src/codegen/metadata,src/codegen/templates,src/handwritten"

We should:

Remove this exclusion
Run ni-python-styleguide fix
Run ni-python-styleguide acknowledge-existing-violations
Update the copy in generated/nidaqmx

The text was updated successfully, but these errors were encountered:

bkeryan added the enhancement label

bkeryan mentioned this issue

Automate Driver Install Experience within nidaqmx Module #512

Merged

1 task

bkeryan mentioned this issue

add slots to DAQmx-property-containing classes #664

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment