From f0facf8c1a3a1d1edd3abd809a1235bbd91a2735 Mon Sep 17 00:00:00 2001 From: charitylxy Date: Sun, 14 Jan 2024 19:22:13 -0600 Subject: [PATCH] Address comments --- CHANGELOG.md | 4 +++- tests/component/test_task.py | 8 ++++---- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 4e826b69..87146347 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -23,7 +23,9 @@ All notable changes to this project will be documented in this file. * ### Merged Pull Requests * ... * ### Major Changes - * Fix naming issues. `AAND_B` is now `A_AND_B`, `R_1` is now `R1`, `R_2` is now `R2`, `R_3` is now `R3` and `R_4` is now `R4`. + * Add support for strain calibration (offset nulling and shunt calibration) + * Fix naming issues: + * Rename `ShuntCalSelect.AAND_B` to `A_AND_B`. * ### Known Issues * ... diff --git a/tests/component/test_task.py b/tests/component/test_task.py index 6e0c3edf..73730756 100644 --- a/tests/component/test_task.py +++ b/tests/component/test_task.py @@ -77,7 +77,7 @@ def test___perform_bridge_shunt_cal___no_errors( skip_unsupported_channels, ) except nidaqmx.DaqError as e: - if e.error_code != -201493: + if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE: raise @@ -91,7 +91,7 @@ def test___perform_bridge_shunt_cal_default___no_errors( try: ai_bridge_task.perform_bridge_shunt_cal(ai_bridge_task.channels.name) except nidaqmx.DaqError as e: - if e.error_code != -201493: + if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE: raise @@ -126,7 +126,7 @@ def test___perform_strain_shunt_cal___no_errors( skip_unsupported_channels, ) except nidaqmx.DaqError as e: - if e.error_code != -201493: + if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE: raise @@ -140,5 +140,5 @@ def test___perform_strain_shunt_cal_default___no_errors( try: ai_strain_gage_task.perform_strain_shunt_cal(ai_strain_gage_task.channels.name) except nidaqmx.DaqError as e: - if e.error_code != -201493: + if e.error_code != DAQmxErrors.SHUNT_CAL_FAILED_OUT_OF_RANGE: raise