Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action link #5

Open
davidhunter08 opened this issue Feb 20, 2019 · 7 comments
Open

Action link #5

davidhunter08 opened this issue Feb 20, 2019 · 7 comments
Labels
component Goes in the 'Components' section of the service manual NHS.UK component on NHS website public-facing

Comments

@davidhunter08
Copy link
Contributor

davidhunter08 commented Feb 20, 2019

Use this issue to discuss the action link in the NHS digital service manual.

@davidhunter08 davidhunter08 added the component Goes in the 'Components' section of the service manual label Feb 20, 2019
@bencullimore bencullimore mentioned this issue Nov 24, 2020
@davidhunter08
Copy link
Contributor Author

Reported issue in the frontend for the SVG icon not scaling when you increase the font size

@thelittlelostgirl79
Copy link

thelittlelostgirl79 commented Jul 26, 2021

I'm questioning whether the green arrow that proceeds the "Find your nearest..." action link is supposed to appear inside an emergency care card - which has a black background? The green arrow is very difficult to see and I'm wondering if it passes our accessibility criteria? Example is here:
action link in emergency care card

@chrimesdev
Copy link
Member

chrimesdev commented Jul 26, 2021

Hey @thelittlelostgirl79, you're right the green arrow is difficult to see, this was an issue previously raised and fixed in v5.0.0 of the NHS.UK frontend library.

How it should look now:

Screenshot 2021-07-26 at 14 51 23

It looks like the service in your example needs updating to the latest version of the frontend library. Which service/website is this on?

@thelittlelostgirl79
Copy link

This is on NHS.UK - I'll let the content designer know who created the page only recently.

@chrimesdev
Copy link
Member

chrimesdev commented Jul 26, 2021

It looks like the NHS website is using an older version of the frontend library so it will not have the new action link on immediate care card styles on there yet.

I will flag this with developers to use the latest version. We shouldn't need anything changing from the content designers point of view as it will get updated automatically.

@thelittlelostgirl79
Copy link

thelittlelostgirl79 commented Jul 26, 2021

Ah, yes please Chris. Thank you!

@anandamaryon1
Copy link
Contributor

Comment copied from (nhsuk/nhsuk-frontend#925 (comment))

Bug Report

What is the issue?

An accessibility audit of our site has flagged the following non-compliance with WCAG Level A: 1.4.1 Use of Colour. Action links rely on colour alone to convey meaning.

WCAG Success Criterion Success Criterion 1.4.1 Use of Colour (Level A): Colour is not used as the only visual means of conveying information, indicating an action, prompting a response, or distinguishing a visual element.

WCAG Sufficient technique G182: Ensuring that additional visual cues are available when text colour differences are used to convey information.

What steps are required to reproduce the issue?

Go to any site that uses action links, e.g.: https://www.nhs.uk/

What was the environment where this issue occurred?

Can be observed on all desktop devices including macOS Sonoma and Windows 11.

Is there anything else you think would be useful in recreating the issue?

This is a core NHS design component; flagging this issue for your consideration

Reply from service manual team

Hi @hiten-livi thank you for sharing your findings.

The action link itself doesn't rely solely on colour, as it has the icon and it's large and bold text. This component has been through accessibility audits before and passed.

We want to ensure we continually improve our designs based on feedback, so I've copied your comments onto the discussion for the action link component (#5). Since I've copied over your comment, I'll now close this ticket.

We'll continue to monitor accessibility feedback on the action link component. If we find that other teams are reporting similar things, we'll revisit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component Goes in the 'Components' section of the service manual NHS.UK component on NHS website public-facing
Development

No branches or pull requests

5 participants