From 4658c92d5e92c09c0eb73a4774425fae4645802b Mon Sep 17 00:00:00 2001 From: Theodor Vararu Date: Fri, 27 Sep 2024 14:00:34 +0300 Subject: [PATCH] Add accessible-autocomplete The stylesheet couldn't be imported using the sass @import directive, so instead we link to it as a separate stylesheet file instead of bundling it in. This is probably more cache-friendly as the autocomplete upstream CSS will change less frequently than our application bundle CSS. --- app/views/layouts/application.html.erb | 1 + config/initializers/assets.rb | 3 +++ package.json | 1 + yarn.lock | 5 +++++ 4 files changed, 10 insertions(+) diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb index 0b283b93a..2a1f816de 100644 --- a/app/views/layouts/application.html.erb +++ b/app/views/layouts/application.html.erb @@ -6,6 +6,7 @@ <%= page_title(@service_name) %> + <%= stylesheet_link_tag "accessible-autocomplete.min", "data-turbo-track": Rails.env.development? ? "" : "reload" %> <%= stylesheet_link_tag "application", "data-turbo-track": Rails.env.development? ? "" : "reload" %> <%= javascript_include_tag "application", "data-turbo-track": Rails.env.development? ? "" : "reload", defer: true %> diff --git a/config/initializers/assets.rb b/config/initializers/assets.rb index 101a2902e..54429c759 100644 --- a/config/initializers/assets.rb +++ b/config/initializers/assets.rb @@ -7,6 +7,9 @@ # Add additional assets to the asset load path. # Rails.application.config.assets.paths << Emoji.images_path +Rails.application.config.assets.paths << Rails.root.join( + "node_modules/accessible-autocomplete/dist" +) # Precompile additional assets. # application.js, application.css, and all non-JS/CSS in the app/assets diff --git a/package.json b/package.json index c1162b1f0..b8a17dac1 100644 --- a/package.json +++ b/package.json @@ -4,6 +4,7 @@ "dependencies": { "@hotwired/stimulus": "^3.2.2", "@hotwired/turbo-rails": "^8.0.10", + "accessible-autocomplete": "^3.0.1", "esbuild": "^0.24.0", "govuk-frontend": "^5.6.0", "idb": "^8.0.0", diff --git a/yarn.lock b/yarn.lock index 59430d238..8d9fad902 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1895,6 +1895,11 @@ abab@^2.0.6: resolved "https://registry.yarnpkg.com/abab/-/abab-2.0.6.tgz#41b80f2c871d19686216b82309231cfd3cb3d291" integrity sha512-j2afSsaIENvHZN2B8GOpF566vZ5WVk5opAiMTvWgaQT8DkbOqsTfvNAvHoRGU2zzP8cPoqys+xHTRDWW8L+/BA== +accessible-autocomplete@^3.0.1: + version "3.0.1" + resolved "https://registry.yarnpkg.com/accessible-autocomplete/-/accessible-autocomplete-3.0.1.tgz#8ddf4934d0b4ba6acb28de486dd505e062cdc86e" + integrity sha512-xMshgc2LT5addvvfCTGzIkRrvhbOFeylFSnSMfS/PdjvvvElZkakCwxO3/yJYBWyi1hi3tZloqOJQ5kqqJtH4g== + acorn-globals@^7.0.0: version "7.0.1" resolved "https://registry.yarnpkg.com/acorn-globals/-/acorn-globals-7.0.1.tgz#0dbf05c44fa7c94332914c02066d5beff62c40c3"