Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify crop settings? Will adding a 'crop' parameter to _config.yml work? #23

Closed
kry8vmedia opened this issue Nov 24, 2016 · 11 comments
Closed

Comments

@kry8vmedia
Copy link

No description provided.

@nhoizey
Copy link
Owner

nhoizey commented Nov 24, 2016

Do you want to apply the same crop to:

  • all images -> global setting
  • every image with the same preset -> preset setting
  • single images -> additional syntax in Liquid tag

@kry8vmedia
Copy link
Author

I would like to add it as a preset setting. I think that would be most flexible for me

@aarongustafson
Copy link
Collaborator

I would love to see support for more of the transformation tools too. I think presets are a good place to start.

@nhoizey
Copy link
Owner

nhoizey commented Mar 15, 2017

@kry8vmedia @aarongustafson I will try to take time soon to look how I can do this!

@aarongustafson
Copy link
Collaborator

aarongustafson commented Mar 16, 2017 via email

@nhoizey
Copy link
Owner

nhoizey commented Mar 16, 2017

@aarongustafson awesome, thanks!

@aarongustafson
Copy link
Collaborator

INCOMING!

@aarongustafson
Copy link
Collaborator

aarongustafson commented May 3, 2017

You should be able to use crop in your presets now: https://github.com/nhoizey/jekyll-cloudinary/blob/master/lib/jekyll/cloudinary.rb#L26

@nhoizey
Copy link
Owner

nhoizey commented May 3, 2017

@aarongustafson do you plan to make a PR with a few additions about this in the README? ;-)

@aarongustafson
Copy link
Collaborator

aarongustafson commented May 5, 2017 via email

@nhoizey
Copy link
Owner

nhoizey commented May 5, 2017

@aarongustafson I created the issue, but I can't assign it to you until you accept my invitation to be a collaborator on the project… ;-)

#27

@nhoizey nhoizey closed this as completed May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants