fix(TranslateHttpLoader): compatibility with Angular 4.3

BREAKING CHANGE: the loader is now only compatible with Angular 4.3+

Author: ocombe

package.json

@@ -31,20 +31,20 @@
   "typings": "index.d.ts",
   "peerDependencies": {
     "@ngx-translate/core": ">=6.0.0",
-    "@angular/core": ">=2.0.0",
-    "@angular/http": ">=2.0.0"
+    "@angular/core": ">=4.3.1",
+    "@angular/http": ">=4.3.1"
   },
   "devDependencies": {
-    "@angular/animations": "4.1.3",
-    "@angular/common": "4.1.3",
-    "@angular/compiler": "4.1.3",
-    "@angular/compiler-cli": "4.1.3",
-    "@angular/core": "4.1.3",
-    "@angular/http": "4.1.3",
+    "@angular/animations": "4.3.1",
+    "@angular/common": "4.3.1",
+    "@angular/compiler": "4.3.1",
+    "@angular/compiler-cli": "4.3.1",
+    "@angular/core": "4.3.1",
+    "@angular/http": "4.3.1",
     "@ngx-translate/core": "7.0.0",
-    "@angular/platform-browser": "4.1.3",
-    "@angular/platform-browser-dynamic": "4.1.3",
-    "@angular/platform-server": "4.1.3",
+    "@angular/platform-browser": "4.3.1",
+    "@angular/platform-browser-dynamic": "4.3.1",
+    "@angular/platform-server": "4.3.1",
     "@types/hammerjs": "2.0.34",
     "@types/jasmine": "2.5.51",
     "@types/node": "7.0.28",

src/http-loader.ts

@@ -1,17 +1,16 @@
-import {Http, Response} from "@angular/http";
+import {HttpClient} from "@angular/common/http";
 import {TranslateLoader} from "@ngx-translate/core";
 import "rxjs/add/operator/map";
 
 export class TranslateHttpLoader implements TranslateLoader {
-    constructor(private http: Http, private prefix: string = "/assets/i18n/", private suffix: string = ".json") {}
+    constructor(private http: HttpClient, private prefix: string = "/assets/i18n/", private suffix: string = ".json") {}
 
     /**
      * Gets the translations from the server
      * @param lang
      * @returns {any}
      */
     public getTranslation(lang: string): any {
-        return this.http.get(`${this.prefix}${lang}${this.suffix}`)
-            .map((res: Response) => res.json());
+        return this.http.get(`${this.prefix}${lang}${this.suffix}`);
     }
 }

tests/http-loader.spec.ts

@@ -1,58 +1,38 @@
 import {Injector} from "@angular/core";
 import {getTestBed, TestBed} from "@angular/core/testing";
-import {
-    BaseRequestOptions,
-    ConnectionBackend,
-    Http,
-    HttpModule,
-    RequestOptions,
-    Response,
-    ResponseOptions, XHRBackend
-} from "@angular/http";
-import {MockBackend, MockConnection} from "@angular/http/testing";
+import {HttpClient} from "@angular/common/http";
+import {HttpClientTestingModule, HttpTestingController} from "@angular/common/http/testing";
 import {TranslateLoader, TranslateModule, TranslateService} from "@ngx-translate/core";
 import {TranslateHttpLoader} from "../index";
 
-const mockBackendResponse = (connection: MockConnection, response: string) => {
-    connection.mockRespond(new Response(new ResponseOptions({body: response})));
-};
-
 describe('TranslateLoader', () => {
     let injector: Injector;
     let translate: TranslateService;
-    let backend: any;
-    let connection: MockConnection; // this will be set when a new connection is emitted from the backend.
+    let http: HttpTestingController;
 
     beforeEach(() => {
         TestBed.configureTestingModule({
             imports: [
-                HttpModule,
+                HttpClientTestingModule,
                 TranslateModule.forRoot({
                     loader: {
                         provide: TranslateLoader,
-                        useFactory: (http: Http) => new TranslateHttpLoader(http),
-                        deps: [Http]
+                        useFactory: (http: HttpClient) => new TranslateHttpLoader(http),
+                        deps: [HttpClient]
                     }
                 })
             ],
-            providers: [
-                {provide: XHRBackend, useClass: MockBackend},
-                {provide: ConnectionBackend, useClass: MockBackend},
-                {provide: RequestOptions, useClass: BaseRequestOptions}
-            ]
+            providers: [TranslateService]
         });
         injector = getTestBed();
-        translate = injector.get(TranslateService);
-        backend = injector.get(XHRBackend);
-        // sets the connection when someone tries to access the backend with an xhr request
-        backend.connections.subscribe((c: MockConnection) => connection = c);
+        translate = TestBed.get(TranslateService);
+        http = TestBed.get(HttpTestingController);
     });
 
     afterEach(() => {
         injector = undefined;
         translate = undefined;
-        backend = undefined;
-        connection = undefined;
+        http = undefined;
     });
 
     it('should be able to provide TranslateHttpLoader', () => {
@@ -70,7 +50,7 @@ describe('TranslateLoader', () => {
         });
 
         // mock response after the xhr request, otherwise it will be undefined
-        mockBackendResponse(connection, '{"TEST": "This is a test", "TEST2": "This is another test"}');
+        http.expectOne('/assets/i18n/en.json').flush({"TEST": "This is a test", "TEST2": "This is another test"});
 
         // this will request the translation from downloaded translations without making a request to the backend
         translate.get('TEST2').subscribe((res: string) => {
@@ -90,21 +70,21 @@ describe('TranslateLoader', () => {
                 expect(translate.instant('TEST')).toEqual('This is a test 2');
             });
 
-            mockBackendResponse(connection, '{"TEST": "This is a test 2"}');
+            http.expectOne('/assets/i18n/en.json').flush({"TEST": "This is a test 2"});
         });
 
         // mock response after the xhr request, otherwise it will be undefined
-        mockBackendResponse(connection, '{"TEST": "This is a test"}');
+        http.expectOne('/assets/i18n/en.json').flush({"TEST": "This is a test"});
     });
 
     it('should be able to reset a lang', (done: Function) => {
         translate.use('en');
-        spyOn(connection, 'mockRespond').and.callThrough();
+        spyOn(http, 'expectOne').and.callThrough();
 
         // this will request the translation from the backend because we use a static files loader for TranslateService
         translate.get('TEST').subscribe((res: string) => {
             expect(res).toEqual('This is a test');
-            expect(connection.mockRespond).toHaveBeenCalledTimes(1);
+            expect(http.expectOne).toHaveBeenCalledTimes(1);
 
             // reset the lang as if it was never initiated
             translate.resetLang('en');
@@ -115,13 +95,13 @@ describe('TranslateLoader', () => {
             setTimeout(() => {
                 translate.get('TEST').subscribe((res2: string) => {
                     expect(res2).toEqual('TEST'); // because the loader is "pristine" as if it was never called
-                    expect(connection.mockRespond).toHaveBeenCalledTimes(1);
+                    expect(http.expectOne).toHaveBeenCalledTimes(1);
                     done();
                 });
             }, 10);
         });
 
         // mock response after the xhr request, otherwise it will be undefined
-        mockBackendResponse(connection, '{"TEST": "This is a test"}');
+        http.expectOne('/assets/i18n/en.json').flush({"TEST": "This is a test"});
     });
 });