From 04766a5f60f5c1bbc62febb54fec262b59b2a12c Mon Sep 17 00:00:00 2001 From: Nathan Glasl Date: Wed, 28 Feb 2018 11:52:15 +1100 Subject: [PATCH] [IMPROVEMENT] Enforcing a suggestion limit when hundreds may exist. --- README.md | 2 +- client/javascript/extensible-search-suggestions.js | 8 +++++++- composer.json | 2 +- src/services/ExtensibleSearchService.php | 4 ++-- 4 files changed, 11 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index f5a9e1b..8e6f52f 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # [extensible search](https://packagist.org/packages/nglasl/silverstripe-extensible-search) -_The current release is **4.0.1**_ +_The current release is **4.1.0**_ > This module allows user customisation and developer extension of a search page instance, including analytics and suggestions. diff --git a/client/javascript/extensible-search-suggestions.js b/client/javascript/extensible-search-suggestions.js index 6746f30..ae53c41 100644 --- a/client/javascript/extensible-search-suggestions.js +++ b/client/javascript/extensible-search-suggestions.js @@ -44,6 +44,12 @@ 'label': term + '' + this.substr(term.length) + '', 'value': this }); + + // Enforce a limit. + + if(options.length === 5) { + return false; + } } }); response(options); @@ -55,7 +61,7 @@ .data('ui-autocomplete')._renderItem = function(ul, item) { return $('
  • ').append($('
    ').html(item.label)).appendTo(ul); - } + }; } }); diff --git a/composer.json b/composer.json index 48ef64a..bd7ce34 100644 --- a/composer.json +++ b/composer.json @@ -32,7 +32,7 @@ }, "extra": { "branch-alias": { - "dev-master": "4.0.x-dev" + "dev-master": "4.1.x-dev" }, "expose": [ "client" diff --git a/src/services/ExtensibleSearchService.php b/src/services/ExtensibleSearchService.php index 79d8a46..dc20e3f 100644 --- a/src/services/ExtensibleSearchService.php +++ b/src/services/ExtensibleSearchService.php @@ -173,7 +173,7 @@ public function getPageSuggestions($pageID, $limit = 0, $approved = true) { // Make sure the search suggestions are unique. - return array_unique($suggestions->column('Term')); + return $suggestions->column('Term'); } return array(); } @@ -209,7 +209,7 @@ public function getSuggestions($term, $pageID, $limit = 5, $approved = true) { // Make sure the search suggestions are unique. - return array_unique($suggestions->column('Term')); + return $suggestions->column('Term'); } } return array();