Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, because I want to set up CI tests of the example modules before merging any significant changes.
Log macros now accept any object that implements
LogTarget
, i.e. requests, events,ngx_conf_t
, etc. Default mask for thengx_log_debug!
is set according to the object type.With all the complexity added, the code still makes 1-2 allocations less than the original variant and gets completely inlined in the release builds.
A few tricky moments:
LogTarget
trait is intentionally kept object-safe, because one of the planned further steps is to offer integration with thelog
facade and that required type erasure viadyn LogTarget
(to be reevaluated).ngx_log_t
that comes from C, points to a writable memory, and doesn't have to satisfy the Rust memory model constraints (as described in thestd::ptr::from_ref
).Fixes #47
Fixes #92