Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to ObservabilityPolicy to require TargetRefs #2524

Open
kate-osborn opened this issue Sep 9, 2024 · 1 comment · May be fixed by #2753
Open

Add validation to ObservabilityPolicy to require TargetRefs #2524

kate-osborn opened this issue Sep 9, 2024 · 1 comment · May be fixed by #2753
Assignees
@salonichf5
Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Milestone
v1.5.0

Comments

@kate-osborn
Copy link
Contributor

kate-osborn commented Sep 9, 2024 •
edited by mpstefan
Loading

The ObservabilityPolicy CRD should require a minimum of 1 TargetRef.

See this convo: #2515 (comment)

  • Will need to bump version of CRD
  • Confirm that bumping the version of the CRD does not affect valid ObservabilityPolicys
  • How do we handle v1alpha1? Deprecation for 3 weeks? Look at Kubernetes doc on CRD versioning and update our own guide.
  • Just follow the doc on how to do versioning changes
@kate-osborn
Copy link
Contributor Author

During refinement let's discuss whether this mandates a version bump

@kate-osborn kate-osborn added this to the v1.5.0 milestone Sep 17, 2024
@kate-osborn kate-osborn added the bug Something isn't working label Sep 17, 2024
@mpstefan mpstefan added size/small Estimated to be completed within ~2 days refined Requirements are refined and the issue is ready to be implemented. labels Sep 30, 2024
@salonichf5 salonichf5 self-assigned this Oct 31, 2024
@salonichf5 salonichf5 linked a pull request Nov 7, 2024 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salonichf5 salonichf5

Labels
bug Something isn't working refined Requirements are refined and the issue is ready to be implemented. size/small Estimated to be completed within ~2 days
Projects
NGINX Gateway Fabric
Status: 👀 In Review
Milestone
v1.5.0
Development

Successfully merging a pull request may close this issue.

Update ObservabilityPolicy API to have minimum one target ref salonichf5/nginx-gateway-fabric
3 participants
@mpstefan @kate-osborn @salonichf5