Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minikube as option for running tests #7018

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Add minikube as option for running tests #7018

merged 4 commits into from
Dec 19, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 18, 2024

Proposed changes

Allow minikube to be used for running e2e tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner December 18, 2024 17:40
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 18, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.74%. Comparing base (c4c6114) to head (9efbde4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7018   +/-   ##
=======================================
  Coverage   52.74%   52.74%           
=======================================
  Files          89       89           
  Lines       20824    20824           
=======================================
  Hits        10983    10983           
  Misses       9387     9387           
  Partials      454      454           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 enabled auto-merge (squash) December 19, 2024 10:02
@pdabelf5 pdabelf5 merged commit 42dd0f6 into main Dec 19, 2024
82 checks passed
@pdabelf5 pdabelf5 deleted the tests/minikube branch December 19, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants