Hotfix: Port numbers need a bigger integer

[saedx1]

Proposed changes

Very simple; an int16 cannot fit port numbers, only uint16 or int32/int64 can fit them.

The current version of NIC breaks on ports greater than 32767 when used with nginx.org/listen-ports or nginx.org/listen-ports-ssl annotations.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

• I have read the CONTRIBUTING doc
• I have added tests that prove my fix is effective or that my feature works
• I have checked that all unit tests pass after adding my changes
• I have updated necessary documentation
• I have rebased my branch onto main
• I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

[jjngx]

@saedx1 Excellent! Thanks for catching this issue!

[jjngx]

🚀

[saedx1]

@jjngx No problem. Would we be able to get a patch release (like v4.0.1 or so)? This is somewhat blocking us.

[jjngx]

@jjngx No problem. Would we be able to get a patch release? This is somewhat blocking us.

We will decide early next week. In the meantime, when this fix gets merged, you will be able to use the edge or build your own image.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.76%. Comparing base (93eec0d) to head (48ea40b).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7054      +/-   ##
==========================================
- Coverage   52.79%   52.76%   -0.03%     
==========================================
  Files          89       89              
  Lines       20827    20827              
==========================================
- Hits        10996    10990       -6     
- Misses       9376     9380       +4     
- Partials      455      457       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vepatel]

Hi @saedx1, can you please create an issue for this based on our contributing guidelines? The upper limit i.e. port 32767 is basically the highest default allowed port for nodeport.
We'd like to know a bit more re the requirements if possible in the issue.

[saedx1]

Closes #7063

[saedx1]

Hi @saedx1, can you please create an issue for this based on our contributing guidelines? The upper limit i.e. port 32767 is basically the highest default allowed port for nodeport. We'd like to know a bit more re the requirements if possible in the issue.

Just for the record, I'll respond here to this as well. This should have nothing to do with NodePorts or the NodePort range.