From ad80b7667851bb87adc3f2d701465fd83ea09aa9 Mon Sep 17 00:00:00 2001 From: Luca Comellini Date: Wed, 28 Feb 2024 11:29:32 -0800 Subject: [PATCH] Move NGINX Bot to GitHub App (#1618) Problem: Some operations are not possible from a GitHub Actions. Solution: Make it into a GitHub App. This will also allow us to have many more functionalities in the future. --- .github/nginx-bot.yml | 5 +++++ .github/workflows/nginx-bot.yml | 35 --------------------------------- .yamllint.yaml | 7 +++---- 3 files changed, 8 insertions(+), 39 deletions(-) create mode 100644 .github/nginx-bot.yml delete mode 100644 .github/workflows/nginx-bot.yml diff --git a/.github/nginx-bot.yml b/.github/nginx-bot.yml new file mode 100644 index 0000000000..871cee5848 --- /dev/null +++ b/.github/nginx-bot.yml @@ -0,0 +1,5 @@ +prAssigneeFromIssueNumber: 583 +warnMissingIssue: true +missingIssueMessage: | + Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. + See [Linking a pull request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) and our [Pull Request Guidelines](../docs/developer/pull-request.md) for more information. diff --git a/.github/workflows/nginx-bot.yml b/.github/workflows/nginx-bot.yml deleted file mode 100644 index beb556db4c..0000000000 --- a/.github/workflows/nginx-bot.yml +++ /dev/null @@ -1,35 +0,0 @@ -name: NGINX Bot - -on: - issues: - types: - - opened - - reopened - - edited - pull_request: - types: - - opened - - reopened - - edited - -concurrency: - group: ${{ github.event.issue.number || github.event.pull_request.number }}-bot - cancel-in-progress: true - -permissions: - issues: write - pull-requests: write - -jobs: - comment: - name: Run the bot - runs-on: ubuntu-22.04 - steps: - - name: Bot Action - uses: lucacome/nginx-bot@main - with: - pr-assignee-from-issue: 583 - warn-missing-issue: true - missing-issue-message: | - Please make sure to include the issue number in the PR description to automatically close the issue when the PR is merged. - See [Linking a pull request to an issue](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) and our [Pull Request Guidelines](../docs/developer/pull-request.md) for more information. diff --git a/.yamllint.yaml b/.yamllint.yaml index 3a77819f42..20470b80df 100644 --- a/.yamllint.yaml +++ b/.yamllint.yaml @@ -1,8 +1,7 @@ --- - yaml-files: - - '*.yaml' - - '*.yml' + - "*.yaml" + - "*.yml" ignore: - deploy/helm-chart/templates/ @@ -39,7 +38,7 @@ rules: allow-non-breakable-words: true allow-non-breakable-inline-mappings: true ignore: | - .github/workflows/ + .github/ deploy/manifests/nginx-gateway.yaml deploy/manifests/crds tests/longevity/manifests/cronjob.yaml