Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typo in templates/controller-lease.yaml #7179

Open
atombrella opened this issue Jan 21, 2025 · 2 comments
Open

[Bug]: Typo in templates/controller-lease.yaml #7179

atombrella opened this issue Jan 21, 2025 · 2 comments
Labels
bug An issue reporting a potential bug needs triage An issue that needs to be triaged

Comments

@atombrella
Copy link

Version

edge

What Kubernetes platforms are you running on?

AKS Azure

Steps to reproduce

This file has a typo. It was introduced in Release 3.7. annotations misses the last :, which causes Helm to stop working when upgrading from an older release.

https://github.com/nginx/kubernetes-ingress/blob/main/charts/nginx-ingress/templates/controller-lease.yaml

{{ if .Values.controller.reportIngressStatus.enableLeaderElection }}
apiVersion: coordination.k8s.io/v1
kind: Lease
metadata:
  name: {{ include "nginx-ingress.leaderElectionName" . }}
  namespace: {{ .Release.Namespace }}
  labels:
    {{- include "nginx-ingress.labels" . | nindent 4 }}
{{- if .Values.controller.reportIngressStatus.annotations }}
  annotations
{{ toYaml .Values.controller.reportIngressStatus.annotations | indent 4 }}
{{- end }}
{{- end }}

Can you please fix it?

@atombrella atombrella added bug An issue reporting a potential bug needs triage An issue that needs to be triaged labels Jan 21, 2025
Copy link

Hi @atombrella thanks for reporting!

Be sure to check out the docs and the Contributing Guidelines while you wait for a human to take a look at this 🙂

Cheers!

@pdabelf5
Copy link
Collaborator

@atombrella thank you for bringing this to our attention. We will look into the problem you have raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug needs triage An issue that needs to be triaged
Projects
Status: Todo ☑
Development

No branches or pull requests

2 participants