Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding label placement needs to handle bottom right position better #720

Open
bradh opened this issue Aug 9, 2019 · 0 comments
Open

Onboarding label placement needs to handle bottom right position better #720

bradh opened this issue Aug 9, 2019 · 0 comments

Comments

@bradh
Copy link
Collaborator

bradh commented Aug 9, 2019

If you attach an onboarding step to an item in the lower right part of the display, it won't be positioned correctly. For example:

      "attachTo": "button[title=Mute]",
      "highlight": "button[title=Mute]"

Will highlight correctly, but will position the tip in the top left part of the display.

To work around it, you need to do something like:

      "attachTo": "button[title=Mute]",
      "position": "top",
      "highlight": "button[title=Mute]",
      "xOffset": -435

The positioning logic (https://github.com/ngageoint/opensphere/blob/master/src/os/ui/onboarding/ngonboarding.js#L288) appears fairly complicated. It would be nice to have fewer options (or at least less interdependence between the options), although this would need to consider existing out-of-tree users of onboarding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bradh