Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused packages: ngrx/core, ngrx/store #25

Open
alexpopdev opened this issue Jul 22, 2016 · 0 comments
Open

Unused packages: ngrx/core, ngrx/store #25

alexpopdev opened this issue Jul 22, 2016 · 0 comments

Comments

@alexpopdev
Copy link

alexpopdev commented Jul 22, 2016

In the package.json file I found references to ngrx/core, ngrx/store and ngrx-store-logger but when I looked through the code I found that they are not actually used.
I think they should be removed as it is confusing for anyone trying to understand the architecture of the app.
It lead me to believe you have a redux implementation side by side with an ngrx\store one (which I don't think is a bad idea after all).
Thanks,
Alex Pop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant