-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can read_services use readProtoFiles2 which has an equivalent of proto_path for imports? #29
Open
sagadasgupta opened this issue
Apr 15, 2020
· 2 comments
· May be fixed by Shehab7osny/grpc#1 or #32
Open
Can read_services use readProtoFiles2 which has an equivalent of proto_path for imports? #29
sagadasgupta opened this issue
Apr 15, 2020
· 2 comments
· May be fixed by Shehab7osny/grpc#1 or #32
Comments
sagadasgupta
changed the title
Can read_services use readProtoFiles2 which is has an equivalent of proto_path for imports?
Can read_services use readProtoFiles2 which has an equivalent of proto_path for imports?
Apr 15, 2020
This seems very reasonable to me; would you need to modify read_services declaration to have proto_path as a parameter also, or can you change only the one line in read_services? |
I think since read_services will call readProtoFiles2 it will have to accept and pass the proto_path to readProtoFiles2. |
Shehab7osny
added a commit
to Shehab7osny/grpc
that referenced
this issue
Apr 23, 2020
This update Closes nfultz#29 It uses readProtoFiles2 which enables importing files from other packages by allowing the user to provide a path (protoPath)
Shehab7osny
added a commit
to Shehab7osny/grpc
that referenced
this issue
Apr 23, 2020
This update Closes nfultz#29 It uses readProtoFiles2 which enables importing files from other packages by allowing the user to provide a path (protoPath)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a proto file that has a few imports on proto files in other packages and readProtoFiles simply blows up with errors because it doesn't know where to find the imports.
readProtoFiles2 was introduced to fix that issue eddelbuettel/rprotobuf#39 and https://www.rdocumentation.org/packages/RProtoBuf/versions/0.4.14/topics/readProtoFiles. So can read_services use readProtoFiles2 and allow us to specify proto_path?
The text was updated successfully, but these errors were encountered: