-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSEED #17
Comments
Hi @dylanmikesell you are right - ideally the code would handle both. It should in fact be straightforward to modify the code to allow loading MSEED files. Most lines referring to SAC (e.g., lines 73, 75, 78, 144, 152, etc.) use it as a string to search for the the corresponding SAC extension. You could add an argument to the functions
Then on lines 324 and 327, you change The only place where this gets tricky is on lines 333 and 334, where there is a check for no data in I hope this helps. |
Okay. Thanks for the tips. I will have a look and work on this. One more question: can we adapt the filename structure requirements? I just converted some mseed to sac using IRIS' mseed2sac function. An example filename looks like YG.SE3.00.HH1.D.2021.200.000001.SAC. io.py cannot find these data even now that they are in SAC format. Are these format 1 and format 2 coming from your own channel naming? Would it be useful to provide different formats, e.g., like msnoise?
My miniseed do not follow your formats either, e.g., SE3.YG.00.HHZ.2021.183. So I need to figure something out. |
@paudetseis, can you tell me what stdata is meant to be in the following lines? lclfiles = list(filter( If you look at what stdata actually is, it is the path given by the --local-data option PATH. Thus, I can never get lclfiles to populate. If you look in the doc of the functions in io.py it says the following.
Thus, I think there might be a bug in the local-data code. Does it work for your own tests? |
@dylanmikesell there might well be a bug in the local-data code. To be honest with you I have never tested this part - it's inherited from other codes written by a collaborator. But yes, the I also like your suggestion to have different naming conventions for the data files. Ultimately I think the scripts need a major overhaul but I don't have the time to spend on this unfortunately. Feel free to have a stab at it and make them work for your application. If your changes end up making it more broadly accessible, can you please generate a PR so I can merge your changes with the Thanks |
Hi @paudetseis. I finally got back to this. I have the local SAC data partially figured out and will submit a PR when done. First, we were misssing a call to My SAC data do not have a user9 header word...and as you stated before, MSEED will not have this either. I am curious, where does user9 come from as a check for no data in your code? If that header set in your own local data? To me it seems like we should just have a check on the st.data length. Here is your code.
If you can provide me a little more insight into user9 I can get this fixed. I noticed a few other issues have popped up about this local directory issue, so I will try to wrap it up quickly. |
Hi @paudetseis, is there any reason on your end to add MSEED read functionality. It seems to me like it should be able to handle both. I have mseed day volumes stored locally. I looked through io.py last night. Seems like a bit of work to fix things to get mseed working. Has anyone else made this request? I can have a go at it, but if no one else has been asking about this functionally, maybe I will just convert my data to SAC.
The text was updated successfully, but these errors were encountered: