Skip to content

Commit de5146a

Browse files
authored
Merge pull request #412 from nf-core/405-adding-depthcutoff-freyja
Add parameter freyja_depthcutoff
2 parents ce72f48 + 66d2cf1 commit de5146a

6 files changed

+38
-16
lines changed

.devcontainer/devcontainer.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,11 @@
1818
"python.linting.flake8Path": "/opt/conda/bin/flake8",
1919
"python.linting.pycodestylePath": "/opt/conda/bin/pycodestyle",
2020
"python.linting.pydocstylePath": "/opt/conda/bin/pydocstyle",
21-
"python.linting.pylintPath": "/opt/conda/bin/pylint"
21+
"python.linting.pylintPath": "/opt/conda/bin/pylint",
2222
},
2323

2424
// Add the IDs of extensions you want installed when the container is created.
25-
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"]
26-
}
27-
}
25+
"extensions": ["ms-python.python", "ms-python.vscode-pylance", "nf-core.nf-core-extensionpack"],
26+
},
27+
},
2828
}

CHANGELOG.md

+9-7
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,18 @@ Thank you to everyone else that has contributed by reporting bugs, enhancements
2020
- [[PR #387](https://github.com/nf-core/viralrecon/pull/387)] - Software closes gracefully when encountering an error
2121
- [[PR #395](https://github.com/nf-core/viralrecon/pull/395)] - Remove minia from default assemblers because it is unreliable
2222
- [[PR #393](https://github.com/nf-core/viralrecon/pull/393)] - Changed primer set to params
23+
- [[PR [#405](https://github.com/nf-core/viralrecon/issues/405)]] - Including parameter `depthcutoff` to freyja demix and boot
2324

2425
### Parameters
2526

26-
| Old parameter | New parameter |
27-
| ------------------- | ------------- |
28-
| `--skip_freyja` | |
29-
| `--freyja_repeats` | |
30-
| `--freyja_db_name` | |
31-
| `--freyja_barcodes` | |
32-
| `--freyja_lineages` | |
27+
| Old parameter | New parameter |
28+
| ---------------------- | ------------- |
29+
| `--skip_freyja` | |
30+
| `--freyja_repeats` | |
31+
| `--freyja_db_name` | |
32+
| `--freyja_barcodes` | |
33+
| `--freyja_lineages` | |
34+
| `--freyja_depthcutoff` | |
3335

3436
> **NB:** Parameter has been **updated** if both old and new parameter information is present.
3537
> **NB:** Parameter has been **added** if just the new parameter information is present.

conf/modules_illumina.config

+8-1
Original file line numberDiff line numberDiff line change
@@ -194,21 +194,28 @@ if (!params.skip_variants) {
194194
if (!params.skip_freyja) {
195195
process {
196196
withName: 'FREYJA_VARIANTS' {
197+
ext.args = {}
197198
publishDir = [
198199
path: { "${params.outdir}/variants/freyja/variants" },
199200
mode: params.publish_dir_mode,
200201
pattern: "*.{tsv,csv}"
201202
]
202203
}
203204
withName: 'FREYJA_DEMIX' {
205+
ext.args = [
206+
params.freyja_depthcutoff ? "--depthcutoff ${params.freyja_depthcutoff}" : '',
207+
].join(' ').trim()
204208
publishDir = [
205209
path: { "${params.outdir}/variants/freyja/demix" },
206210
mode: params.publish_dir_mode,
207211
pattern: "*.{tsv,csv}"
208212
]
209213
}
210214
withName: 'FREYJA_BOOT' {
211-
ext.args = '--boxplot pdf'
215+
ext.args = [
216+
params.freyja_depthcutoff ? "--depthcutoff ${params.freyja_depthcutoff}" : '',
217+
'--boxplot pdf',
218+
].join(' ').trim()
212219
publishDir = [
213220
path: { "${params.outdir}/variants/freyja/bootstrap" },
214221
mode: params.publish_dir_mode,

conf/modules_nanopore.config

+9-3
Original file line numberDiff line numberDiff line change
@@ -240,17 +240,23 @@ if (!params.skip_freyja) {
240240
}
241241

242242
withName: 'FREYJA_DEMIX' {
243+
ext.args = [
244+
params.freyja_depthcutoff ? "--depthcutoff ${params.freyja_depthcutoff}" : '',
245+
].join(' ').trim()
243246
publishDir = [
244-
path: { "${params.outdir}/${params.artic_minion_caller}/freyja/demix" },
247+
path: { "${params.outdir}/variants/freyja/demix" },
245248
mode: params.publish_dir_mode,
246249
pattern: "*.{tsv,csv}"
247250
]
248251
}
249252

250253
withName: 'FREYJA_BOOT' {
251-
ext.args = '--boxplot pdf'
254+
ext.args = [
255+
params.freyja_depthcutoff ? "--depthcutoff ${params.freyja_depthcutoff}" : '',
256+
'--boxplot pdf',
257+
].join(' ').trim()
252258
publishDir = [
253-
path: { "${params.outdir}/${params.artic_minion_caller}/freyja/bootstrap" },
259+
path: { "${params.outdir}/variants/freyja/bootstrap" },
254260
mode: params.publish_dir_mode,
255261
pattern: "*.{tsv,csv,pdf}"
256262
]

nextflow.config

+1
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ params {
4343
max_multiqc_email_size = '25.MB'
4444
skip_freyja = false
4545
freyja_repeats = 100
46+
freyja_depthcutoff = null
4647
freyja_db_name = 'freyja_db'
4748
freyja_barcodes = null
4849
freyja_lineages = null

nextflow_schema.json

+7-1
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@
253253
},
254254
"skip_freyja": {
255255
"type": "boolean",
256-
"fa_icon": "fas fast-forward",
256+
"fa_icon": "fas fa-forward",
257257
"description": "Skip freyja deep SARS-CoV-2 variant analysis using a depth weighted approach."
258258
},
259259
"freyja_db_name": {
@@ -262,6 +262,12 @@
262262
"fa_icon": "fas fa-folder-open",
263263
"description": "Specify the name where to store UShER database (default: 'freyja_db')."
264264
},
265+
"freyja_depthcutoff": {
266+
"type": "number",
267+
"description": "Specify a coverage depth minimum which excludes sites with coverage less than the specified value",
268+
"fa_icon": "fas fa-hand-paper",
269+
"help_text": "Using the `depthcutoff` option may result in some distinct lineages now having identical barcodes, which are grouped into the format `[lineage]-like(num)` (based on their shared phylogeny) in the output."
270+
},
265271
"freyja_repeats": {
266272
"type": "integer",
267273
"default": 100,

0 commit comments

Comments
 (0)