Skip to content

Commit d47e3ff

Browse files
authored
Merge pull request #127 from nschcolnicov/fix_vep
Fixed VEP s3 bucket path
2 parents 0429e57 + 3de9b74 commit d47e3ff

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2121

2222
- [#97](https://github.com/nf-core/rnavar/pull/97) - Update all gatk4 modules to disable JVM hotspot
2323
- [#124](https://github.com/nf-core/rnavar/pull/124) - Fixed s3 bucket path in conditional statement for SnpEff cache
24+
- [#127](https://github.com/nf-core/rnavar/pull/127) - Fixed s3 bucket path in conditional statement for VEP cache
2425

2526
### Dependencies
2627

workflows/rnavar.nf

+5-5
Original file line numberDiff line numberDiff line change
@@ -151,24 +151,24 @@ if (params.snpeff_cache && params.annotate_tools && (params.annotate_tools.split
151151

152152
if (params.vep_cache && params.annotate_tools && (params.annotate_tools.split(',').contains("vep") || params.annotate_tools.split(',').contains("merge"))) {
153153
def vep_annotation_cache_key = ''
154-
if (params.vep_cache == "s3://annotation-cache/vep_cache") {
154+
if (params.vep_cache == "s3://annotation-cache/vep_cache/") {
155155
vep_annotation_cache_key = "${params.vep_cache_version}_${params.vep_genome}/"
156156
} else {
157157
vep_annotation_cache_key = params.use_annotation_cache_keys ? "${params.vep_cache_version}_${params.vep_genome}/" : ""
158158
}
159-
def vep_cache_dir = "${vep_annotation_cache_key}${params.vep_cache_version}_${params.vep_genome}/${params.vep_species}"
159+
def vep_cache_dir = "${vep_annotation_cache_key}/${params.vep_species}"
160160
def vep_cache_path_full = file("$params.vep_cache/$vep_cache_dir", type: 'dir')
161161
if ( !vep_cache_path_full.exists() || !vep_cache_path_full.isDirectory() ) {
162-
if (params.vep_cache == "s3://annotation-cache/vep_cache") {
162+
if (params.vep_cache == "s3://annotation-cache/vep_cache/") {
163163
error("This path is not available within annotation-cache. Please check https://annotation-cache.github.io/ to create a request for it.")
164164
} else {
165165
error("Files within --vep_cache invalid. Make sure there is a directory named ${vep_cache_dir} in ${params.vep_cache}.\nhttps://nf-co.re/sarek/usage#how-to-customise-snpeff-and-vep-annotation")
166166
}
167167
}
168168
vep_cache = Channel.fromPath(file("${params.vep_cache}/${vep_annotation_cache_key}"), checkIfExists: true).collect()
169-
} else if (params.annotate_tools && (params.annotate_tools.split(',').contains("vep") || params.annotate_tools.split(',').contains("merge")) && !params.download_cache) {
169+
} else if (params.annotate_tools && (params.annotate_tools.split(',').contains("vep") || params.annotate_tools.split(',').contains("merge")) && !params.download_cache) {
170170
error("No cache for VEP or automatic download of said cache has been detected.\nPlease refer to https://nf-co.re/sarek/docs/usage/#how-to-customise-snpeff-and-vep-annotation for more information.")
171-
} else vep_cache = []
171+
} else vep_cache = []
172172

173173
vep_extra_files = []
174174

0 commit comments

Comments
 (0)