Template updates v2.13 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
noticed that #16 has been closed, but you can have a look at it if needed |
maxulysse
reviewed
Feb 21, 2024
Comment on lines
+18
to
+20
| fasta = null | ||
| fai = null | ||
| dict = null |
There was a problem hiding this comment.
Yeah, otherwise you get these warnings
WARN: Access to undefined parameter `dict` -- Initialise it to a default value eg. `params.dict = some_value`
WARN: Access to undefined parameter `fai` -- Initialise it to a default value eg. `params.fai = some_value`
WARN: Access to undefined parameter `fasta` -- Initialise it to a default value eg. `params.fasta = some_value
maxulysse
reviewed
Feb 21, 2024
nextflow_schema.json
Outdated
| @@ -143,6 +143,7 @@ | |||
| "title": "Reference genome options", | |||
| "type": "object", | |||
| "fa_icon": "fas fa-dna", | |||
| "required": ["fasta"], | |||
There was a problem hiding this comment.
huh.. is this not required by cnvkit?
maxulysse
reviewed
Feb 21, 2024
subworkflows/local/utils_nfcore_createpanelrefs_pipeline/main.nf
Outdated
Show resolved
Hide resolved
|
replace #18 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).